query-frontend+api: add X-Request-ID field and other context field to start call log #4769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aymericDD
force-pushed
the
feature/4768
branch
from
0081e76
to
7201cba
Compare
aymericDD
force-pushed
the
feature/4768
branch
2 times, most recently
from
f59a7a4
to
ecf79c5
Compare
GiedriusS
reviewed
Oct 15, 2021
aymericDD
changed the title
aymericDD
force-pushed
the
feature/4768
branch
from
ecf79c5
to
2c475d6
Compare
|
The CHANGELOG is updated @GiedriusS 🙂 |
Add "X-REQUEST-ID" to identify requests and link log related to the same request. Add "http.method" to know witch request is executed. Add "http.method_name" to know witch method is called. Signed-off-by: Aymeric <aymeric.daurelle@cdiscount.com>
aymericDD
force-pushed
the
feature/4768
branch
from
2c475d6
to
241827c
Compare
|
Sorry for the delay. I was in vacation. The conflict is fixed. 🙂 |
akanshat
pushed a commit
to akanshat/thanos
that referenced
this pull request
Oct 30, 2021
Add "X-REQUEST-ID" to identify requests and link log related to the same request. Add "http.method" to know witch request is executed. Add "http.method_name" to know witch method is called. Signed-off-by: Aymeric <aymeric.daurelle@cdiscount.com> Co-authored-by: Aymeric <aymeric.daurelle@cdiscount.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add more context to link start call with finished call.
Signed-off-by: Aymeric aymeric.daurelle@cdiscount.com
Fix issue #4768 .
Changes
Verification
Tested functionally on local.