Do not upload meta files to obj store #5110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Romain Dauby <romain.dauby@gmail.com>
Signed-off-by: Romain Dauby <romain.dauby@gmail.com>
2 tasks
|
@yeya24 the two links that timed out with mdox are responding on my workstation/network. |
I think maybe that's just flaky. I re ran the tests and CI passed now. |
Nicholaswang
pushed a commit
to Nicholaswang/thanos
that referenced
this pull request
Mar 6, 2022
* Do not upload meta files to obj store Signed-off-by: Romain Dauby <romain.dauby@gmail.com> * Update CHANGELOG Signed-off-by: Romain Dauby <romain.dauby@gmail.com> Signed-off-by: Nicholaswang <wzhever@gmail.com>
GiedriusS
added a commit
to vinted/thanos
that referenced
this pull request
Mar 6, 2023
Bring back thanos-io#5110 into our fork so that it would be possible to reconstruct the exact remote object storage state when the compactor does something bad. Signed-off-by: Giedrius Statkevičius <giedrius.statkevicius@vinted.com>
GiedriusS
added a commit
to vinted/thanos
that referenced
this pull request
Mar 16, 2023
Bring back thanos-io#5110 into our fork so that it would be possible to reconstruct the exact remote object storage state when the compactor does something bad. Signed-off-by: Giedrius Statkevičius <giedrius.statkevicius@vinted.com>
GiedriusS
added a commit
to vinted/thanos
that referenced
this pull request
Jun 7, 2023
Bring back thanos-io#5110 into our fork so that it would be possible to reconstruct the exact remote object storage state when the compactor does something bad. Signed-off-by: Giedrius Statkevičius <giedrius.statkevicius@vinted.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Romain Dauby romain.dauby@gmail.com
Fix #3839
Changes
Verification
Unit test, e2e tests passed locally and also in my fork with Github actions.