[file-sd-part-2] Query e2e test uses different service discovery options #554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivan-valkov
force-pushed
the
file-sd-query-test
branch
from
98d95c0
to
4dc205f
Compare
bwplotka
reviewed
Oct 5, 2018
test/e2e/query_test.go
Outdated
| }, | ||
| } { | ||
| //TODO(ivan): delete this | ||
| fmt.Printf("Starting TestQuerySimple with service discovery: %v\n", name) |
There was a problem hiding this comment.
if ok := t.Run(t, name, "" ) {
}
test/e2e/query_test.go
Outdated
| @@ -17,9 +17,38 @@ import ( | |||
| "github.com/prometheus/common/model" | |||
| ) | |||
|
|
|||
| func TestQuery(t *testing.T) { | |||
| for name, conf := range map[string]sdConfig{ | |||
There was a problem hiding this comment.
pkg/compact/retention_test.go:21
ivan-valkov
force-pushed
the
file-sd-query
branch
from
6c9aca9
to
1ff8e29
Compare
ivan-valkov
force-pushed
the
file-sd-query-test
branch
from
4dc205f
to
89afd05
Compare
ivan-valkov
force-pushed
the
file-sd-query
branch
from
1ff8e29
to
2105322
Compare
ivan-valkov
force-pushed
the
file-sd-query-test
branch
from
89afd05
to
b07ebc2
Compare
ivan-valkov
changed the title
ivan-valkov
force-pushed
the
file-sd-query-test
branch
from
e46e182
to
92a046a
Compare
domgreen
reviewed
Oct 12, 2018
test/e2e/query_test.go
Outdated
| }) | ||
| } | ||
| } | ||
|
|
||
| // TestQuerySimple runs a setup of Prometheus servers, sidecars, and query nodes and verifies that |
There was a problem hiding this comment.
nit update comment ot new name
ivan-valkov
force-pushed
the
file-sd-query-test
branch
from
92a046a
to
5093da5
Compare
domgreen
requested changes
Oct 12, 2018
ivan-valkov
force-pushed
the
file-sd-query-test
branch
2 times, most recently
from
940080a
to
1e77f44
Compare
ivan-valkov
force-pushed
the
file-sd-query-test
branch
from
1e77f44
to
49718a7
Compare
* Added file sd to rule
ivan-valkov
pushed a commit
that referenced
this pull request
Oct 16, 2018
Addressed PR comments More pr comments addressed Added logs and metrics when removing dups Removed redundant check Added flag for file sd refresh interval Changed default fileSD interval to 5m make docs [file-sd-part-2] Query e2e test uses different service discovery options (#554) * Query e2e tests different sd options
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref: #492
Changes
The query e2e test now runs 3 times with different service discovery options:
Verification
The tests pass