Build with Go 1.19 #5753
Merged
Build with Go 1.19 #5753
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sylvain Rabot <sylvain@abstraction.fr>
Signed-off-by: Sylvain Rabot <sylvain@abstraction.fr>
GiedriusS
reviewed
Oct 4, 2022
Signed-off-by: Sylvain Rabot <sylvain@abstraction.fr>
Signed-off-by: Sylvain Rabot <sylvain@abstraction.fr>
GiedriusS
previously approved these changes
Oct 4, 2022
Signed-off-by: Sylvain Rabot <sylvain@abstraction.fr>
Signed-off-by: Sylvain Rabot <sylvain@abstraction.fr>
``` WARN [runner] The linter 'deadcode' is deprecated (since v1.49.0) due to: The owner seems to have abandoned the linter. Replaced by unused. WARN [runner] The linter 'varcheck' is deprecated (since v1.49.0) due to: The owner seems to have abandoned the linter. Replaced by unused. WARN [runner] The linter 'structcheck' is deprecated (since v1.49.0) due to: The owner seems to have abandoned the linter. Replaced by unused. WARN [linters context] structcheck is disabled because of generics. You can track the evolution of the generics support by following the golangci/golangci-lint#2649. ``` Signed-off-by: Sylvain Rabot <sylvain@abstraction.fr>
Signed-off-by: Sylvain Rabot <sylvain@abstraction.fr>
Signed-off-by: Sylvain Rabot <sylvain@abstraction.fr>
Signed-off-by: Sylvain Rabot <sylvain@abstraction.fr>
Signed-off-by: Sylvain Rabot <sylvain@abstraction.fr>
Signed-off-by: Sylvain Rabot <sylvain@abstraction.fr>
GiedriusS
reviewed
Oct 5, 2022
douglascamata
pushed a commit
to douglascamata/thanos
that referenced
this pull request
Oct 6, 2022
* Build with Go 1.19 Signed-off-by: Sylvain Rabot <sylvain@abstraction.fr> * Run go fmt with go 1.19 Signed-off-by: Sylvain Rabot <sylvain@abstraction.fr> * Add changelog entry Signed-off-by: Sylvain Rabot <sylvain@abstraction.fr> * Revert go version in go.mod Signed-off-by: Sylvain Rabot <sylvain@abstraction.fr> * Upgrade faillint to v1.11.0 Signed-off-by: Sylvain Rabot <sylvain@abstraction.fr> * Upgrade github.com/golangci/golangci-lint to v1.49.0 Signed-off-by: Sylvain Rabot <sylvain@abstraction.fr> * Remove deprecated linters ``` WARN [runner] The linter 'deadcode' is deprecated (since v1.49.0) due to: The owner seems to have abandoned the linter. Replaced by unused. WARN [runner] The linter 'varcheck' is deprecated (since v1.49.0) due to: The owner seems to have abandoned the linter. Replaced by unused. WARN [runner] The linter 'structcheck' is deprecated (since v1.49.0) due to: The owner seems to have abandoned the linter. Replaced by unused. WARN [linters context] structcheck is disabled because of generics. You can track the evolution of the generics support by following the golangci/golangci-lint#2649. ``` Signed-off-by: Sylvain Rabot <sylvain@abstraction.fr> * Regen proto files Signed-off-by: Sylvain Rabot <sylvain@abstraction.fr> * Fix typo Signed-off-by: Sylvain Rabot <sylvain@abstraction.fr> * Format docs Signed-off-by: Sylvain Rabot <sylvain@abstraction.fr> * Upgrade gopsutil to v3.22.9 Signed-off-by: Sylvain Rabot <sylvain@abstraction.fr> * Display diff in the check-docs target Signed-off-by: Sylvain Rabot <sylvain@abstraction.fr> * Fix macOS path in docs/components/tools.md Signed-off-by: Sylvain Rabot <sylvain@abstraction.fr> Signed-off-by: Sylvain Rabot <sylvain@abstraction.fr>
utukJ
pushed a commit
to utukJ/thanos
that referenced
this pull request
Oct 13, 2022
* Build with Go 1.19 Signed-off-by: Sylvain Rabot <sylvain@abstraction.fr> * Run go fmt with go 1.19 Signed-off-by: Sylvain Rabot <sylvain@abstraction.fr> * Add changelog entry Signed-off-by: Sylvain Rabot <sylvain@abstraction.fr> * Revert go version in go.mod Signed-off-by: Sylvain Rabot <sylvain@abstraction.fr> * Upgrade faillint to v1.11.0 Signed-off-by: Sylvain Rabot <sylvain@abstraction.fr> * Upgrade github.com/golangci/golangci-lint to v1.49.0 Signed-off-by: Sylvain Rabot <sylvain@abstraction.fr> * Remove deprecated linters ``` WARN [runner] The linter 'deadcode' is deprecated (since v1.49.0) due to: The owner seems to have abandoned the linter. Replaced by unused. WARN [runner] The linter 'varcheck' is deprecated (since v1.49.0) due to: The owner seems to have abandoned the linter. Replaced by unused. WARN [runner] The linter 'structcheck' is deprecated (since v1.49.0) due to: The owner seems to have abandoned the linter. Replaced by unused. WARN [linters context] structcheck is disabled because of generics. You can track the evolution of the generics support by following the golangci/golangci-lint#2649. ``` Signed-off-by: Sylvain Rabot <sylvain@abstraction.fr> * Regen proto files Signed-off-by: Sylvain Rabot <sylvain@abstraction.fr> * Fix typo Signed-off-by: Sylvain Rabot <sylvain@abstraction.fr> * Format docs Signed-off-by: Sylvain Rabot <sylvain@abstraction.fr> * Upgrade gopsutil to v3.22.9 Signed-off-by: Sylvain Rabot <sylvain@abstraction.fr> * Display diff in the check-docs target Signed-off-by: Sylvain Rabot <sylvain@abstraction.fr> * Fix macOS path in docs/components/tools.md Signed-off-by: Sylvain Rabot <sylvain@abstraction.fr> Signed-off-by: Sylvain Rabot <sylvain@abstraction.fr> Signed-off-by: utukj <utukphd@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Build with Go 1.19
Verification