Update storage.md with Oracle Cloud Infrastructure provider #5778
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yeya24
previously approved these changes
Oct 10, 2022
aarontams
force-pushed
the
aatam/syncup_storage-md_with_oci_provider
branch
from
d0fcb38
to
f55a41b
Compare
Sorry, forgot about it. |
squat
reviewed
Oct 10, 2022
docs/storage.md
Outdated
|
|
||
| #### API Signing Key | ||
|
|
||
| The default API signing key authentication provider leverages same [configuration as the OCI CLI](https://docs.oracle.com/en-us/iaas/Content/API/Concepts/cliconcepts.htm) which is usually stored in at `$HOME/.oci/config` or via variable names starting with the string `OCI_CLI`. You can also use environment variables that start with `TF_VAR`. If the same configuration is found in multiple places the provider will prefer the first one. |
There was a problem hiding this comment.
You can also use environment variables that start with
TF_VAR.
This sounds funny to me. What does Thanos's OCI storage implementation have to do with Teratogen
Terraform?
There was a problem hiding this comment.
@squat
Where did you see Teratogen? Can you clarify? Thx!
There was a problem hiding this comment.
I'll assume @squat had an autocorrect mishap, and he meant simply Terraform :), I assume he refers to why we're mentioning the TF_VAR here.
Signed-off-by: aaron.tam <aaron.tam@oracle.com>
aarontams
force-pushed
the
aatam/syncup_storage-md_with_oci_provider
branch
from
f55a41b
to
555045a
Compare
matej-g
approved these changes
Oct 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Issue: #5592
This PR sync up https://github.com/thanos-io/thanos/blob/main/docs/storage.md and https://github.com/thanos-io/objstore/blob/main/README.md. See issue for details.
Verification
This is just documentation sync up. No test is needed.