Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Bump objstore package to latest main #5779

Merged
merged 3 commits into from Oct 11, 2022

Conversation

yeya24
Copy link
Contributor

@yeya24 yeya24 commented Oct 10, 2022

Signed-off-by: Ben Ye benye@amazon.com

Fixes #5663

  • I added CHANGELOG entry for this change.
  • Change is not relevant to the end user.

Changes

Brings in support for S3 storage class.

Verification

Signed-off-by: Ben Ye <benye@amazon.com>
Signed-off-by: Ben Ye <benye@amazon.com>
@fpetkovski
Copy link
Contributor

Looks like CI failure is related to this change

Signed-off-by: Ben Ye <benye@amazon.com>
Copy link
Contributor

@fpetkovski fpetkovski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Collaborator

@matej-g matej-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Ben, looks good!

@matej-g matej-g merged commit ecb26ec into thanos-io:main Oct 11, 2022
utukJ pushed a commit to utukJ/thanos that referenced this pull request Oct 13, 2022
* bump objstore package to latest main

Signed-off-by: Ben Ye <benye@amazon.com>

* update changelog and doc

Signed-off-by: Ben Ye <benye@amazon.com>

* fix docs check

Signed-off-by: Ben Ye <benye@amazon.com>

Signed-off-by: Ben Ye <benye@amazon.com>
Signed-off-by: utukj <utukphd@gmail.com>
@yeya24 yeya24 deleted the update-objstore branch October 23, 2022 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support S3 storage class
3 participants