store: add histogram for postings size #5814
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a metric that shows the distribution of how many postings (in bytes) were needed for each Series() call. Useful for determining limits. Signed-off-by: Giedrius Statkevičius <giedrius.statkevicius@vinted.com>
GiedriusS
force-pushed
the
postings_metric
branch
from
9415e19
to
b979361
Compare
fpetkovski
approved these changes
Oct 24, 2022
matej-g
approved these changes
Oct 24, 2022
| @@ -1137,6 +1146,7 @@ func (s *BucketStore) Series(req *storepb.SeriesRequest, srv storepb.Store_Serie | |||
| s.metrics.cachedPostingsCompressionTimeSeconds.WithLabelValues(labelDecode).Add(stats.CachedPostingsDecompressionTimeSum.Seconds()) | |||
| s.metrics.cachedPostingsOriginalSizeBytes.Add(float64(stats.CachedPostingsOriginalSizeSum)) | |||
| s.metrics.cachedPostingsCompressedSizeBytes.Add(float64(stats.CachedPostingsCompressedSizeSum)) | |||
| s.metrics.postingsSizeBytes.Observe(float64(int(stats.PostingsFetchedSizeSum) + int(stats.PostingsTouchedSizeSum))) | |||
There was a problem hiding this comment.
@GiedriusS: Am I correct in assuming that "touched" means downloaded from cache and "fetched" means downloaded from object storage? Seems like so but I am not sure. 🤔
There was a problem hiding this comment.
One thing to note is that, we also update PostingsTouchedSizeSum when we write encoded postings back to cache even if we fetch those postings from object storage. I feel like this behavior makes the metric not that accurate.
There was a problem hiding this comment.
I think this deserves fixing and its own issue, @yeya24. WDYT?
There was a problem hiding this comment.
Yeah I don't know if this is by design. @GiedriusS Do you know more about this
|
@GiedriusS thanks a lot for this. 🙇 |
fpetkovski
pushed a commit
to fpetkovski/thanos
that referenced
this pull request
Oct 25, 2022
Add a metric that shows the distribution of how many postings (in bytes) were needed for each Series() call. Useful for determining limits. Signed-off-by: Giedrius Statkevičius <giedrius.statkevicius@vinted.com> Signed-off-by: Giedrius Statkevičius <giedrius.statkevicius@vinted.com>
ngraham20
pushed a commit
to ngraham20/thanos
that referenced
this pull request
May 18, 2023
Add a metric that shows the distribution of how many postings (in bytes) were needed for each Series() call. Useful for determining limits. Signed-off-by: Giedrius Statkevičius <giedrius.statkevicius@vinted.com> Signed-off-by: Giedrius Statkevičius <giedrius.statkevicius@vinted.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a metric that shows the distribution of how many postings (in bytes) were needed for each Series() call. Useful for determining limits.
Signed-off-by: Giedrius Statkevičius giedrius.statkevicius@vinted.com