Support vertical sharding for label_join and label_replace functions #5889
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yeya24
force-pushed
the
support-sharding-label-functions
branch
from
a0afd1f
to
0f8da3f
Compare
Signed-off-by: Ben Ye <benye@amazon.com>
Signed-off-by: Ben Ye <benye@amazon.com>
yeya24
force-pushed
the
support-sharding-label-functions
branch
from
d9ee315
to
5c644a7
Compare
fpetkovski
approved these changes
Nov 15, 2022
|
@fpetkovski Thanks, this makes sense. For our current use case, current support for these label manipulation functions should be good enough. I will merge this then. |
Merged
3 tasks
ngraham20
pushed a commit
to ngraham20/thanos
that referenced
this pull request
May 18, 2023
…hanos-io#5889) * support vertical sharding for label_join and label_replace functions Signed-off-by: Ben Ye <benye@amazon.com> * update changelog Signed-off-by: Ben Ye <benye@amazon.com> * fix doc Signed-off-by: Ben Ye <benye@amazon.com> Signed-off-by: Ben Ye <benye@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ben Ye benye@amazon.com
Even if the query contains label manipulation functions like
label_joinandlabel_replace, as long as there is no conflict between sharding labels and the dynamic destinations labels specified by the function, then we should be fine to shard.For example, for query
sum by (pod, dst_label) (label_join(metric, "dst_label", ",", "src_label")),dst_labelis the dynamic label and we sum by (pod, dst_label), we could just shard bypodin this case.Note: if we could push down the
label_joinandlabel_replacefunction to the store level while matching series, we could also support sharding dynamic labels. This could be a follow up if we think it makes sense.Changes
Support vertical sharding for label_join and label_replace functions
Verification
Updated unit tests