Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cache: Fixed redis cache to use multi batch size config value #5893

Merged
merged 1 commit into from Nov 12, 2022

Conversation

abbyssoul
Copy link
Contributor

@abbyssoul abbyssoul commented Nov 12, 2022

Signed-off-by: Ivan Ryabov abbyssoul@gmail.com

  • I added CHANGELOG entry for this change.
  • Change is not relevant to the end user.

Changes

Cache: fixed redis client not respecting SetMultiBatchSize config value.

Verification

hanjm
hanjm previously approved these changes Nov 12, 2022
Copy link
Member

@hanjm hanjm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

CHANGELOG.md Outdated Show resolved Hide resolved
Signed-off-by: Ivan Ryabov <abbyssoul@gmail.com>
Copy link
Contributor

@yeya24 yeya24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

@yeya24 yeya24 merged commit 1aba885 into thanos-io:main Nov 12, 2022
@abbyssoul abbyssoul deleted the fix-redis-setmulti branch November 13, 2022 01:20
ngraham20 pushed a commit to ngraham20/thanos that referenced this pull request May 18, 2023
Signed-off-by: Ivan Ryabov <abbyssoul@gmail.com>

Signed-off-by: Ivan Ryabov <abbyssoul@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants