test:e2e:receive: Add tests to ensure response codes are correct #5976
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philipgough
force-pushed
the
409-test
branch
4 times, most recently
from
a59551a
to
fad0c9f
Compare
Signed-off-by: Philip Gough <philip.p.gough@gmail.com>
Signed-off-by: Philip Gough <philip.p.gough@gmail.com>
philipgough
force-pushed
the
409-test
branch
from
fad0c9f
to
2c235e6
Compare
|
Hello 👋 Looks like there was no activity on this amazing PR for the last 30 days. |
|
Closing for now as promised, let us know if you need this to be reopened! 🤗 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
As per the title, tests the behaviour of receive in terms of delivering the correct status code to the client for known unrecoverable failures.
Happy to extend it with further cases if it makes sense but when checking out #4831, it was unclear to me what the actual behaviour from Thanos was.
Verification