Sidecar: Loads the TLS certificate during startup. #5995
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maheshbaliga
force-pushed
the
validate-tls-cert-key-files
branch
from
3ddb06d
to
297b958
Compare
|
Seems like there are some conflicts. Care to fix them? 😄 |
|
@GiedriusS, Sure. Will fix it. |
auto-merge was automatically disabled
January 2, 2023 15:00
Head branch was pushed to by a user without write access
GiedriusS
previously approved these changes
Jan 2, 2023
Signed-off-by: maheshbaliga <mahesh.baliga@infracloud.io>
auto-merge was automatically disabled
January 2, 2023 16:47
Head branch was pushed to by a user without write access
maheshbaliga
force-pushed
the
validate-tls-cert-key-files
branch
from
e029dc8
to
ffafaf8
Compare
|
@GiedriusS, the conflict has been resolved. Kindly merge the same. |
Kartik-Garg
pushed a commit
to infracloudio/thanos
that referenced
this pull request
Jan 16, 2023
Signed-off-by: maheshbaliga <mahesh.baliga@infracloud.io> Signed-off-by: maheshbaliga <mahesh.baliga@infracloud.io> Signed-off-by: Kartik-Garg <kartik.garg@infracloud.io>
ngraham20
pushed a commit
to ngraham20/thanos
that referenced
this pull request
Apr 17, 2023
Signed-off-by: maheshbaliga <mahesh.baliga@infracloud.io> Signed-off-by: maheshbaliga <mahesh.baliga@infracloud.io>
ngraham20
pushed a commit
to ngraham20/thanos
that referenced
this pull request
Apr 17, 2023
Signed-off-by: maheshbaliga <mahesh.baliga@infracloud.io> Signed-off-by: maheshbaliga <mahesh.baliga@infracloud.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes [#5223] [#4923]
Changes
The sidecar did not validate the certificate and key while starting; Reading and parsing of the certificate were done only when the client initiated the TLS handshake with the sidecar. This is when the certificate related issues surfaced.
With this code change, these files are now loaded and checked by the sidecar when it starts.
Verification
Tested the fix by adding unit tests. Also, by running the sidecar and query components with TLS configurations.