Upgrade Prometheus to v0.41.0 #6010
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rabenhorst
force-pushed
the
prometheus-v0.41.0
branch
from
f0ee4ea
to
64437fb
Compare
rabenhorst
force-pushed
the
prometheus-v0.41.0
branch
from
e22b1d3
to
3cba089
Compare
fpetkovski
reviewed
Jan 5, 2023
| if err := index.ReadOffsetTable(r.b, r.toc.PostingsOffsetTable, func(key []string, off uint64, _ int) error { | ||
| if len(key) != 2 { | ||
| return errors.Errorf("unexpected key length for posting table %d", len(key)) | ||
| if err := index.ReadPostingsOffsetTable(r.b, r.toc.PostingsOffsetTable, func(name, value []byte, postingsOffset uint64, _ int) error { |
There was a problem hiding this comment.
Is this taken from Prometheus?
There was a problem hiding this comment.
fpetkovski
previously approved these changes
Jan 9, 2023
yeya24
previously approved these changes
Jan 11, 2023
rabenhorst
force-pushed
the
prometheus-v0.41.0
branch
from
3cba089
to
69757bb
Compare
Signed-off-by: Sebastian Rabenhorst <sebastian.rabenhorst@shopify.com>
Signed-off-by: Sebastian Rabenhorst <sebastian.rabenhorst@shopify.com>
Signed-off-by: Sebastian Rabenhorst <sebastian.rabenhorst@shopify.com>
Signed-off-by: Sebastian Rabenhorst <sebastian.rabenhorst@shopify.com>
rabenhorst
force-pushed
the
prometheus-v0.41.0
branch
from
69757bb
to
b092b96
Compare
Done. |
fpetkovski
approved these changes
Jan 13, 2023
saswatamcode
approved these changes
Jan 14, 2023
Kartik-Garg
pushed a commit
to infracloudio/thanos
that referenced
this pull request
Jan 16, 2023
* Updated Prometheus to v0.41.0 Signed-off-by: Sebastian Rabenhorst <sebastian.rabenhorst@shopify.com> * Added changelog entry Signed-off-by: Sebastian Rabenhorst <sebastian.rabenhorst@shopify.com> * Fixed tsOverrideAppender GetRef Signed-off-by: Sebastian Rabenhorst <sebastian.rabenhorst@shopify.com> * ran go mot tidy Signed-off-by: Sebastian Rabenhorst <sebastian.rabenhorst@shopify.com> Signed-off-by: Sebastian Rabenhorst <sebastian.rabenhorst@shopify.com> Signed-off-by: Kartik-Garg <kartik.garg@infracloud.io>
ngraham20
pushed a commit
to ngraham20/thanos
that referenced
this pull request
Apr 17, 2023
* Updated Prometheus to v0.41.0 Signed-off-by: Sebastian Rabenhorst <sebastian.rabenhorst@shopify.com> * Added changelog entry Signed-off-by: Sebastian Rabenhorst <sebastian.rabenhorst@shopify.com> * Fixed tsOverrideAppender GetRef Signed-off-by: Sebastian Rabenhorst <sebastian.rabenhorst@shopify.com> * ran go mot tidy Signed-off-by: Sebastian Rabenhorst <sebastian.rabenhorst@shopify.com> Signed-off-by: Sebastian Rabenhorst <sebastian.rabenhorst@shopify.com>
ngraham20
pushed a commit
to ngraham20/thanos
that referenced
this pull request
Apr 17, 2023
* Updated Prometheus to v0.41.0 Signed-off-by: Sebastian Rabenhorst <sebastian.rabenhorst@shopify.com> * Added changelog entry Signed-off-by: Sebastian Rabenhorst <sebastian.rabenhorst@shopify.com> * Fixed tsOverrideAppender GetRef Signed-off-by: Sebastian Rabenhorst <sebastian.rabenhorst@shopify.com> * ran go mot tidy Signed-off-by: Sebastian Rabenhorst <sebastian.rabenhorst@shopify.com> Signed-off-by: Sebastian Rabenhorst <sebastian.rabenhorst@shopify.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Sebastian Rabenhorst sebastian.rabenhorst@shopify.com
Upgrade Prometheus to version v0.41.0 and fixed binary reader so it works with optimized posting offset table reading (prometheus/prometheus#11535).
Changes
v0.41.0Verification