Fix Receiver panic when querying uninitialized TSDBs #6067
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Receivers currently panic when retrieving labels for a TSDB that is being initialized. The reason for this is that the tenant is added to the tenants map and the TSDB is started in the background. When retrieving labels, the MultiTSDB creates Clients for each TSDB, even if a TSDB is not yet ready. Signed-off-by: Filip Petkovski <filip.petkovsky@gmail.com>
Signed-off-by: Filip Petkovski <filip.petkovsky@gmail.com>
saswatamcode
previously approved these changes
Jan 24, 2023
|
Not sure but CI failure might be related? 👁️ |
Signed-off-by: Filip Petkovski <filip.petkovsky@gmail.com>
GiedriusS
approved these changes
Jan 24, 2023
rabenhorst
pushed a commit
to rabenhorst/thanos
that referenced
this pull request
Jan 24, 2023
* Fix Receiver panic when querying uninitialized TSDBs Receivers currently panic when retrieving labels for a TSDB that is being initialized. The reason for this is that the tenant is added to the tenants map and the TSDB is started in the background. When retrieving labels, the MultiTSDB creates Clients for each TSDB, even if a TSDB is not yet ready. Signed-off-by: Filip Petkovski <filip.petkovsky@gmail.com> * Add CHANGELOG Signed-off-by: Filip Petkovski <filip.petkovsky@gmail.com> * Gracefully terminate test Signed-off-by: Filip Petkovski <filip.petkovsky@gmail.com> Signed-off-by: Filip Petkovski <filip.petkovsky@gmail.com> Signed-off-by: Sebastian Rabenhorst <sebastian.rabenhorst@shopify.com>
sshantel
pushed a commit
to sshantel/thanos
that referenced
this pull request
Jan 28, 2023
* Fix Receiver panic when querying uninitialized TSDBs Receivers currently panic when retrieving labels for a TSDB that is being initialized. The reason for this is that the tenant is added to the tenants map and the TSDB is started in the background. When retrieving labels, the MultiTSDB creates Clients for each TSDB, even if a TSDB is not yet ready. Signed-off-by: Filip Petkovski <filip.petkovsky@gmail.com> * Add CHANGELOG Signed-off-by: Filip Petkovski <filip.petkovsky@gmail.com> * Gracefully terminate test Signed-off-by: Filip Petkovski <filip.petkovsky@gmail.com> Signed-off-by: Filip Petkovski <filip.petkovsky@gmail.com>
ngraham20
pushed a commit
to ngraham20/thanos
that referenced
this pull request
Apr 17, 2023
* Fix Receiver panic when querying uninitialized TSDBs Receivers currently panic when retrieving labels for a TSDB that is being initialized. The reason for this is that the tenant is added to the tenants map and the TSDB is started in the background. When retrieving labels, the MultiTSDB creates Clients for each TSDB, even if a TSDB is not yet ready. Signed-off-by: Filip Petkovski <filip.petkovsky@gmail.com> * Add CHANGELOG Signed-off-by: Filip Petkovski <filip.petkovsky@gmail.com> * Gracefully terminate test Signed-off-by: Filip Petkovski <filip.petkovsky@gmail.com> Signed-off-by: Filip Petkovski <filip.petkovsky@gmail.com>
ngraham20
pushed a commit
to ngraham20/thanos
that referenced
this pull request
Apr 17, 2023
* Fix Receiver panic when querying uninitialized TSDBs Receivers currently panic when retrieving labels for a TSDB that is being initialized. The reason for this is that the tenant is added to the tenants map and the TSDB is started in the background. When retrieving labels, the MultiTSDB creates Clients for each TSDB, even if a TSDB is not yet ready. Signed-off-by: Filip Petkovski <filip.petkovsky@gmail.com> * Add CHANGELOG Signed-off-by: Filip Petkovski <filip.petkovsky@gmail.com> * Gracefully terminate test Signed-off-by: Filip Petkovski <filip.petkovsky@gmail.com> Signed-off-by: Filip Petkovski <filip.petkovsky@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Receivers currently panic when retrieving labels for a TSDB that is being initialized. The reason for this is that the tenant is added to the tenants map and the TSDB is started in the background. When retrieving labels, the MultiTSDB creates Clients for each TSDB, even if a TSDB is not yet ready.
Adding a tenant to the tenants map: https://github.com/thanos-io/thanos/blob/main/pkg/receive/multitsdb.go#L562
Setting the underlying TSDB: https://github.com/thanos-io/thanos/blob/main/pkg/receive/multitsdb.go#L533
Retrieving the TSDB: https://github.com/thanos-io/thanos/blob/main/pkg/receive/multitsdb.go#L166
Fixes #6047
Signed-off-by: Filip Petkovski filip.petkovsky@gmail.com
Changes
Verification