Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

objstore: Update to latest #6104

Merged
merged 1 commit into from Feb 9, 2023

Conversation

farodin91
Copy link
Contributor

@farodin91 farodin91 commented Feb 7, 2023

  • I added CHANGELOG entry for this change.
  • Change is not relevant to the end user.

Changes

Updates Objstore to latest.

Includes:

  • Dependency updates
  • s3: add support for session token

Verification

@farodin91 farodin91 force-pushed the objstore-update-to-latest branch 3 times, most recently from 96856c4 to 0724a66 Compare February 7, 2023 15:34
saswatamcode
saswatamcode previously approved these changes Feb 8, 2023
Copy link
Member

@saswatamcode saswatamcode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Can you run make docs to fix the check?
Seems like the unit test failure is also related.

pkg/compact/planner_test.go Outdated Show resolved Hide resolved
pkg/compact/planner_test.go Outdated Show resolved Hide resolved
@farodin91 farodin91 force-pushed the objstore-update-to-latest branch 2 times, most recently from 44dbd47 to 0ac0a93 Compare February 9, 2023 06:49
@pull-request-size pull-request-size bot added size/L and removed size/M labels Feb 9, 2023
Signed-off-by: Jan Jansen <jan.jansen@gdata.de>
@saswatamcode saswatamcode merged commit f9d07a3 into thanos-io:main Feb 9, 2023
@farodin91 farodin91 deleted the objstore-update-to-latest branch February 9, 2023 10:00
ngraham20 pushed a commit to ngraham20/thanos that referenced this pull request Apr 17, 2023
Signed-off-by: Jan Jansen <jan.jansen@gdata.de>
ngraham20 pushed a commit to ngraham20/thanos that referenced this pull request Apr 17, 2023
Signed-off-by: Jan Jansen <jan.jansen@gdata.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants