Store: Use Histograms for bucket metrics #6131
Conversation
SuperQ
force-pushed
the
store_histograms
branch
from
2571fcf
to
dd8eb51
Compare
Convert store bucket metrics from Summary to Histogram so that they can be aggregated over multiple instances. Signed-off-by: SuperQ <superq@gmail.com>
SuperQ
force-pushed
the
store_histograms
branch
from
dd8eb51
to
7d533e9
Compare
SuperQ
changed the title
|
I'm not sure what's up with that e2e test. Will poke at it tomorrow. |
|
Oh, looks like it was just a flaky test. |
|
@SuperQ @saswatamcode @yeya24: I think we rushed too much with this one. This is kind of a big breaking change for everyone already using these metrics, which exist since a while. I understand Thanos doesn't offer any breaking change guarantees, but why wasn't a deprecation applied? What is the motivation to change these metrics from summaries to histograms right now? Is aggregation the only reason? Wouldn't it be better to wait and use native histograms at least? Currently the dashboards mixins and examples that were using these metrics are broken because of the change. |
|
Sorry for the quick merge and thanks @douglascamata for raising the point. We should take actions to fix the mixins and examples for sure before we do next release.
Thanos is still at 0.X release so breaking changes across releases are allowed. I see we made breaking changes in the past as well so this should be fine. We just need to mention the breaking change clearly in our changelog to notify our user. |
Update store dashboard for summary to histogram changes. * Followup to thanos-io#6131 * Update changelog to note breaking changes. Signed-off-by: SuperQ <superq@gmail.com>
Update store dashboard for summary to histogram changes. * Followup to thanos-io#6131 * Update changelog to note breaking changes. Signed-off-by: SuperQ <superq@gmail.com>
Update store dashboard for summary to histogram changes. * Followup to thanos-io#6131 * Update changelog to note breaking changes. Signed-off-by: SuperQ <superq@gmail.com>
Update store dashboard for summary to histogram changes. * Followup to #6131 * Update changelog to note breaking changes. Signed-off-by: SuperQ <superq@gmail.com>
Convert store bucket metrics from Summary to Histogram so that they can be aggregated over multiple instances. Signed-off-by: SuperQ <superq@gmail.com>
Update store dashboard for summary to histogram changes. * Followup to thanos-io#6131 * Update changelog to note breaking changes. Signed-off-by: SuperQ <superq@gmail.com>
Convert store bucket metrics from Summary to Histogram so that they can be aggregated over multiple instances. Signed-off-by: SuperQ <superq@gmail.com>
Update store dashboard for summary to histogram changes. * Followup to thanos-io#6131 * Update changelog to note breaking changes. Signed-off-by: SuperQ <superq@gmail.com>
Changes
Convert store bucket metrics from Summary to Histogram so that they can be aggregated over multiple instances.
Verification