extprom: fix test #6591
Merged
extprom: fix test #6591
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix the test by using proto.Equal() instead of using the not deterministic String(). See https://github.com/protocolbuffers/protobuf-go/blob/master/internal/encoding/text/encode.go#L229. Fixes #6590 Signed-off-by: Giedrius Statkevičius <giedrius.statkevicius@vinted.com>
GiedriusS
force-pushed
the
fix_extprom_testrs
branch
from
c90f370
to
c1e0b3a
Compare
GiedriusS
added a commit
to vinted/thanos
that referenced
this pull request
Aug 10, 2023
Fix the test by using proto.Equal() instead of using the not deterministic String(). See https://github.com/protocolbuffers/protobuf-go/blob/master/internal/encoding/text/encode.go#L229. Fixes thanos-io#6590 Signed-off-by: Giedrius Statkevičius <giedrius.statkevicius@vinted.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the test by using proto.Equal() instead of using the not deterministic String(). See
https://github.com/protocolbuffers/protobuf-go/blob/master/internal/encoding/text/encode.go#L229.
Fixes #6590