query/endpointset: fix races #6599
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
GiedriusS
commented
Aug 9, 2023
•
GiedriusS
commented
- Consistently hold mutex while accessing er.metadata
- Capture range loop variable
- Remove getStatus() helper as it was encouraging bad practices - it returns a pointer to a struct but its internal members are not protected as the mutex is used for the whole struct's protection.
- Consistently hold mutex while accessing er.metadata - Capture range loop variable Signed-off-by: Giedrius Statkevičius <giedrius.statkevicius@vinted.com>
GiedriusS
force-pushed
the
fix_endpointset_races
branch
from
28f344b
to
088f283
Compare
GiedriusS
force-pushed
the
fix_endpointset_races
branch
from
466e568
to
62bf67a
Compare
Signed-off-by: Giedrius Statkevičius <giedrius.statkevicius@vinted.com>
GiedriusS
force-pushed
the
fix_endpointset_races
branch
from
62bf67a
to
d9e1cfe
Compare
yeya24
approved these changes
Aug 9, 2023
GiedriusS
added a commit
to vinted/thanos
that referenced
this pull request
Aug 10, 2023
* query/endpointset: fix races - Consistently hold mutex while accessing er.metadata - Capture range loop variable Signed-off-by: Giedrius Statkevičius <giedrius.statkevicius@vinted.com> * query/endpointset: fix getStatus() race Signed-off-by: Giedrius Statkevičius <giedrius.statkevicius@vinted.com> --------- Signed-off-by: Giedrius Statkevičius <giedrius.statkevicius@vinted.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.