Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix mutable stringset memory usage #6669

Merged
merged 1 commit into from Aug 28, 2023
Merged

Fix mutable stringset memory usage #6669

merged 1 commit into from Aug 28, 2023

Conversation

fpetkovski
Copy link
Contributor

This commit fixes the Insert function for the mutable stringset to only insert unique labels instead of adding every label to the set.

  • I added CHANGELOG entry for this change.
  • Change is not relevant to the end user.

Changes

Verification

@fpetkovski
Fix mutable stringset memory usage
a125676 
This commit fixes the Insert function for the mutable stringset
to only insert unique labels instead of adding every label to the set.

Signed-off-by: Filip Petkovski <filip.petkovsky@gmail.com>
saswatamcode
saswatamcode approved these changes Aug 28, 2023
View reviewed changes
Copy link
Member

@saswatamcode saswatamcode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@saswatamcode saswatamcode mentioned this pull request Aug 28, 2023
Closed
MichaHoffmann
MichaHoffmann approved these changes Aug 28, 2023
View reviewed changes
Copy link
Contributor

@MichaHoffmann MichaHoffmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@saswatamcode saswatamcode enabled auto-merge (squash) August 28, 2023 10:08
@saswatamcode saswatamcode merged commit bda19eb into thanos-io:main Aug 28, 2023
16 checks passed
saswatamcode pushed a commit to saswatamcode/thanos that referenced this pull request Aug 28, 2023
@fpetkovski @saswatamcode
Fix mutable stringset memory usage (thanos-io#6669)
7fbc950 
This commit fixes the Insert function for the mutable stringset
to only insert unique labels instead of adding every label to the set.

Signed-off-by: Filip Petkovski <filip.petkovsky@gmail.com>
saswatamcode added a commit that referenced this pull request Aug 28, 2023
@saswatamcode @MichaHoffmann @fpetkovski
Cut patch release v0.32.1 (#6670)
5bf3a9e 
* store: fix error handling in decodePostings (#6650)

Signed-off-by: Michael Hoffmann <mhoffm@posteo.de>

* store: fix ignored error in postings (#6654)

Signed-off-by: Michael Hoffmann <mhoffm@posteo.de>

* Store: fix bufio pool handling (#6655)

Signed-off-by: Michael Hoffmann <mhoffm@posteo.de>

* Fix mutable stringset memory usage (#6669)

This commit fixes the Insert function for the mutable stringset
to only insert unique labels instead of adding every label to the set.

Signed-off-by: Filip Petkovski <filip.petkovsky@gmail.com>

* Cut patch release v0.32.1

Signed-off-by: Saswata Mukherjee <saswataminsta@yahoo.com>

---------

Signed-off-by: Michael Hoffmann <mhoffm@posteo.de>
Signed-off-by: Filip Petkovski <filip.petkovsky@gmail.com>
Signed-off-by: Saswata Mukherjee <saswataminsta@yahoo.com>
Co-authored-by: Michael Hoffmann <mhoffm@posteo.de>
Co-authored-by: Filip Petkovski <filip.petkovsky@gmail.com>
saswatamcode added a commit that referenced this pull request Aug 28, 2023
@saswatamcode @MichaHoffmann @fpetkovski
Cut patch release v0.32.1 (#6670) (#6673)
76ab183 
* store: fix error handling in decodePostings (#6650)



* store: fix ignored error in postings (#6654)



* Store: fix bufio pool handling (#6655)



* Fix mutable stringset memory usage (#6669)

This commit fixes the Insert function for the mutable stringset
to only insert unique labels instead of adding every label to the set.



* Cut patch release v0.32.1



---------

Signed-off-by: Michael Hoffmann <mhoffm@posteo.de>
Signed-off-by: Filip Petkovski <filip.petkovsky@gmail.com>
Signed-off-by: Saswata Mukherjee <saswataminsta@yahoo.com>
Co-authored-by: Michael Hoffmann <mhoffm@posteo.de>
Co-authored-by: Filip Petkovski <filip.petkovsky@gmail.com>
@chenrui333 chenrui333 mentioned this pull request Aug 28, 2023
Merged
coleenquadros pushed a commit to coleenquadros/thanos that referenced this pull request Sep 18, 2023
@fpetkovski @coleenquadros
Fix mutable stringset memory usage (thanos-io#6669)
d7eeb77 
This commit fixes the Insert function for the mutable stringset
to only insert unique labels instead of adding every label to the set.

Signed-off-by: Filip Petkovski <filip.petkovsky@gmail.com>
coleenquadros pushed a commit to coleenquadros/thanos that referenced this pull request Sep 18, 2023
@saswatamcode @MichaHoffmann
@fpetkovski @coleenquadros
Cut patch release v0.32.1 (thanos-io#6670) (thanos-io#6673)
55bc1f1 
* store: fix error handling in decodePostings (thanos-io#6650)



* store: fix ignored error in postings (thanos-io#6654)



* Store: fix bufio pool handling (thanos-io#6655)



* Fix mutable stringset memory usage (thanos-io#6669)

This commit fixes the Insert function for the mutable stringset
to only insert unique labels instead of adding every label to the set.



* Cut patch release v0.32.1



---------

Signed-off-by: Michael Hoffmann <mhoffm@posteo.de>
Signed-off-by: Filip Petkovski <filip.petkovsky@gmail.com>
Signed-off-by: Saswata Mukherjee <saswataminsta@yahoo.com>
Co-authored-by: Michael Hoffmann <mhoffm@posteo.de>
Co-authored-by: Filip Petkovski <filip.petkovsky@gmail.com>
coleenquadros pushed a commit to coleenquadros/thanos that referenced this pull request Sep 18, 2023
@saswatamcode @MichaHoffmann
@fpetkovski @coleenquadros
Cut patch release v0.32.1 (thanos-io#6670)
623fdf5 
* store: fix error handling in decodePostings (thanos-io#6650)

Signed-off-by: Michael Hoffmann <mhoffm@posteo.de>

* store: fix ignored error in postings (thanos-io#6654)

Signed-off-by: Michael Hoffmann <mhoffm@posteo.de>

* Store: fix bufio pool handling (thanos-io#6655)

Signed-off-by: Michael Hoffmann <mhoffm@posteo.de>

* Fix mutable stringset memory usage (thanos-io#6669)

This commit fixes the Insert function for the mutable stringset
to only insert unique labels instead of adding every label to the set.

Signed-off-by: Filip Petkovski <filip.petkovsky@gmail.com>

* Cut patch release v0.32.1

Signed-off-by: Saswata Mukherjee <saswataminsta@yahoo.com>

---------

Signed-off-by: Michael Hoffmann <mhoffm@posteo.de>
Signed-off-by: Filip Petkovski <filip.petkovsky@gmail.com>
Signed-off-by: Saswata Mukherjee <saswataminsta@yahoo.com>
Co-authored-by: Michael Hoffmann <mhoffm@posteo.de>
Co-authored-by: Filip Petkovski <filip.petkovsky@gmail.com>
coleenquadros pushed a commit to coleenquadros/thanos that referenced this pull request Sep 18, 2023
@saswatamcode @MichaHoffmann
@fpetkovski @coleenquadros
Cut patch release v0.32.1 (thanos-io#6670)
2e7887b 
* store: fix error handling in decodePostings (thanos-io#6650)

Signed-off-by: Michael Hoffmann <mhoffm@posteo.de>

* store: fix ignored error in postings (thanos-io#6654)

Signed-off-by: Michael Hoffmann <mhoffm@posteo.de>

* Store: fix bufio pool handling (thanos-io#6655)

Signed-off-by: Michael Hoffmann <mhoffm@posteo.de>

* Fix mutable stringset memory usage (thanos-io#6669)

This commit fixes the Insert function for the mutable stringset
to only insert unique labels instead of adding every label to the set.

Signed-off-by: Filip Petkovski <filip.petkovsky@gmail.com>

* Cut patch release v0.32.1

Signed-off-by: Saswata Mukherjee <saswataminsta@yahoo.com>

---------

Signed-off-by: Michael Hoffmann <mhoffm@posteo.de>
Signed-off-by: Filip Petkovski <filip.petkovsky@gmail.com>
Signed-off-by: Saswata Mukherjee <saswataminsta@yahoo.com>
Co-authored-by: Michael Hoffmann <mhoffm@posteo.de>
Co-authored-by: Filip Petkovski <filip.petkovsky@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MichaHoffmann MichaHoffmann MichaHoffmann approved these changes

@saswatamcode saswatamcode saswatamcode approved these changes

Assignees
No one assigned
Labels
size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@fpetkovski @MichaHoffmann @saswatamcode