Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Store: store responses should always be sorted #6706

Merged
merged 4 commits into from Sep 15, 2023
Merged

Store: store responses should always be sorted #6706

merged 4 commits into from Sep 15, 2023

Commits on Sep 14, 2023

  1. Store: always sort, just compare labelset in proxy heap 

    Signed-off-by: Michael Hoffmann <mhoffm@posteo.de>
    @mhoffm-aiven @MichaHoffmann
    mhoffm-aiven authored and MichaHoffmann committed Sep 14, 2023
    Copy the full SHA
    aab24f1 View commit details
    Browse the repository at this point in the history

  2. Store: add escape hatch to skip store resorting 

    Signed-off-by: Michael Hoffmann <mhoffm@posteo.de>
    @MichaHoffmann
    MichaHoffmann committed Sep 14, 2023
    Copy the full SHA
    ae8b083 View commit details
    Browse the repository at this point in the history

  3. Store: remove stringset 

    This is the wrong approach to detect if we need to resort. It cannot
detect if we might end up with an unsorted series set if we add
extLabels.

Signed-off-by: Michael Hoffmann <mhoffm@posteo.de>
    @MichaHoffmann
    MichaHoffmann committed Sep 14, 2023
    Copy the full SHA
    2a10d70 View commit details
    Browse the repository at this point in the history

  4. Docs: drop paragraph about deduplication on inner labels 

    Signed-off-by: Michael Hoffmann <mhoffm@posteo.de>
    @MichaHoffmann
    MichaHoffmann committed Sep 14, 2023
    Copy the full SHA
    b928701 View commit details
    Browse the repository at this point in the history