Add latency histogram for fetching index cache #6749
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ben Ye <benye@amazon.com>
Signed-off-by: Ben Ye <benye@amazon.com>
fpetkovski
reviewed
Sep 25, 2023
fpetkovski
approved these changes
Sep 26, 2023
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Add a new histogram
thanos_store_index_cache_fetch_duration_secondsto record the latency of fetching data from index cache.This is useful because now there is no metric to do that. We only have cache client specific metrics, like how long it takes to fetch from memcached:
thanos_memcached_operation_duration_seconds.The down side of the existing
thanos_memcached_operation_duration_secondsmetric is that it is the duration of a single get multi call only. So if there are multiple batches that histogram doesn't reflect the total time used to fetch from cache. Also it cannot differentiate fetching postings, series or expanded postings.Verification