Expose index cache ttl config for remote caches #6773
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yeya24
force-pushed
the
expose-index-cache-ttl
branch
from
3b06b20
to
1e2c1c8
Compare
Signed-off-by: Ben Ye <benye@amazon.com>
yeya24
force-pushed
the
expose-index-cache-ttl
branch
from
1e2c1c8
to
d4ecbe7
Compare
|
Thanks @saswatamcode |
coleenquadros
pushed a commit
to coleenquadros/thanos
that referenced
this pull request
Oct 19, 2023
Signed-off-by: Ben Ye <benye@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Allow configurable TTL for index caches in memcached and redis. This should allow items to be cached for longer time and beneficial for long term queries.
Verification