Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Query Frontend: Add tenant label to metrics #6887

Merged
merged 2 commits into from Jan 2, 2024
Merged

Query Frontend: Add tenant label to metrics #6887

merged 2 commits into from Jan 2, 2024

Conversation

jacobbaungard
Copy link
Contributor

@jacobbaungard jacobbaungard commented Nov 10, 2023 •
edited

  • I added CHANGELOG entry for this change.
  • Change is not relevant to the end user.

Changes

  • Adds a tenant label to the HTTP metrics which are exported by the Query Frontend.

Verification

  • Added E2E testcase

@jacobbaungard
Query Frontend: Add tenant label to metrics
019d30d 
This commit adds a tenant label to the HTTP metrics which are exported
by the Query Frontend.

Signed-off-by: Jacob Baungard Hansen <jacobbaungard@redhat.com>
douglascamata
douglascamata approved these changes Dec 18, 2023
View reviewed changes
Copy link
Contributor

@douglascamata douglascamata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚢

yeya24
yeya24 approved these changes Dec 20, 2023
View reviewed changes
Copy link
Contributor

@yeya24 yeya24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

saswatamcode
saswatamcode approved these changes Jan 2, 2024
View reviewed changes
Copy link
Member

@saswatamcode saswatamcode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@saswatamcode saswatamcode merged commit 0fc308c into thanos-io:main Jan 2, 2024
19 of 20 checks passed
hanyuting8 pushed a commit to hanyuting8/thanos that referenced this pull request Jan 19, 2024
@jacobbaungard @hanyuting8
Query Frontend: Add tenant label to metrics (thanos-io#6887)
4bc5883 
This commit adds a tenant label to the HTTP metrics which are exported
by the Query Frontend.

Signed-off-by: Jacob Baungard Hansen <jacobbaungard@redhat.com>
Signed-off-by: hanyuting8 <hytxidian@163.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@douglascamata douglascamata douglascamata approved these changes

@yeya24 yeya24 yeya24 approved these changes

@saswatamcode saswatamcode saswatamcode approved these changes

Assignees
No one assigned
Labels
size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jacobbaungard @douglascamata @yeya24 @saswatamcode