cmd: make bucket upload command take lset from flags

[MichaHoffmann]

• I added CHANGELOG entry for this change.
• Change is not relevant to the end user.

Changes

• tools bucket upload-blocks should get lset from flags ( which is nicely in-line with ruler and receiver then too )
• fixed deadlock because of missing actor function on the command
• is changlog needed here since the original command was not yet released?

Verification

[nicolastakashi]

Just a note On docs would be nice show how to pass multiple label values.

Besides that LGTM 🙌

[yeya24]

Umm, why we don't keep the previous functionality as well? Taking lset from flag can be an additional flag. But I am fine to merge this change.

[MichaHoffmann]

Umm, why we don't keep the previous functionality as well? Taking lset from flag can be an additional flag. But I am fine to merge this change.

I think it might be redundant, if we have prometheus around its arguable that we know its ext labels; we can just read prometheus config and put the labels here

[yeya24]

Since @nicolastakashi 's usecase is in Prometheus operator, I think it would be nice to get this value dynamically rather than specifying ext labels manually, considering multi cluster scenario.

But I am fine if he is ok with it

[MichaHoffmann]

One second, during tests i found there is a deadlock somewhere, ill try to debug and include fix here to!

Edit: found and fixed it.

[yeya24]

What's the fix for deadlock?
It is hard to figure it out from your changes as it is in a single commit.
Let's try to use multiple commits since we always squash at the end.

[MichaHoffmann]

What's the fix for deadlock? It is hard to figure it out from your changes as it is in a single commit. Let's try to use multiple commits since we always squash at the end.

No actor on g, it would hang in main on g.Run() when I debugged it in dlv

[yeya24]

Thanks