Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI: Don't always force tracing #7062

Merged
merged 1 commit into from
Jan 15, 2024
Merged

UI: Don't always force tracing #7062

merged 1 commit into from
Jan 15, 2024

Conversation

jacobbaungard
Copy link
Contributor

  • I added CHANGELOG entry for this change.
  • Change is not relevant to the end user.

Changes

  • TraceID : Fetching TraceID #6973 seemed to have introduced a small bug that always sets "force tracing" to be true, regardless of whether the checkbox is checked or not. This PR reverts to the previous behavior ensuring we respect the checkbox in the UI.

Verification

  • Tested manually.

@jacobbaungard
UI: Don't always force tracing
ed0995b 
Forced tracing was.. Forced true always, even if the checkbox in the UI
to enable tracing was not actually checked.

Signed-off-by: Jacob Baungard Hansen <jacobbaungard@redhat.com>
GiedriusS
GiedriusS approved these changes Jan 15, 2024
View reviewed changes
Copy link
Member

@GiedriusS GiedriusS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙇

@GiedriusS GiedriusS enabled auto-merge (squash) January 15, 2024 10:00
@GiedriusS GiedriusS merged commit a7e8a64 into thanos-io:main Jan 15, 2024
20 checks passed
@jacobbaungard jacobbaungard deleted the dont-always-force-tracing branch January 16, 2024 13:48
hanyuting8 pushed a commit to hanyuting8/thanos that referenced this pull request Jan 19, 2024
@jacobbaungard @hanyuting8
UI: Don't always force tracing (thanos-io#7062)
dbf3c5c 
Forced tracing was.. Forced true always, even if the checkbox in the UI
to enable tracing was not actually checked.

Signed-off-by: Jacob Baungard Hansen <jacobbaungard@redhat.com>
Signed-off-by: hanyuting8 <hytxidian@163.com>
hanyuting8 pushed a commit to hanyuting8/thanos that referenced this pull request Jan 19, 2024
@jacobbaungard @hanyuting8
UI: Don't always force tracing (thanos-io#7062)
67f886b 
Forced tracing was.. Forced true always, even if the checkbox in the UI
to enable tracing was not actually checked.

Signed-off-by: Jacob Baungard Hansen <jacobbaungard@redhat.com>
Signed-off-by: hanyuting8 <hytxidian@163.com>
jnyi pushed a commit to jnyi/thanos that referenced this pull request Apr 4, 2024
@jacobbaungard @jnyi
UI: Don't always force tracing (thanos-io#7062)
9514b72 
Forced tracing was.. Forced true always, even if the checkbox in the UI
to enable tracing was not actually checked.

Signed-off-by: Jacob Baungard Hansen <jacobbaungard@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GiedriusS GiedriusS GiedriusS approved these changes

Assignees
No one assigned
Labels
size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jacobbaungard @GiedriusS