Fix lazy postings with zero length #7083
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ben Ye <benye@amazon.com>
Signed-off-by: Ben Ye <benye@amazon.com>
|
Thanks @MichaHoffmann |
3 tasks
jnyi
pushed a commit
to jnyi/thanos
that referenced
this pull request
Apr 4, 2024
* fix lazy postings with zero length Signed-off-by: Ben Ye <benye@amazon.com> * changelog Signed-off-by: Ben Ye <benye@amazon.com> * unit tests Signed-off-by: Ben Ye <benye@amazon.com> * fix doc Signed-off-by: Ben Ye <benye@amazon.com> --------- Signed-off-by: Ben Ye <benye@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
When lazy expanded postings enabled, we will have expanded postings using partial matchers and matchers that will be evaluated lazily. However, it is possible that with partial matchers, the expanded postings already have 0 length then there is no need to evaluate lazy postings.
In this case, there is a bug that the expanded postings will not be cached. So add a check to return
emptyLazyPostingsif length is 0. SinceemtpyLazyPostingsdoesn't have any matchers, it will be cached here https://github.com/thanos-io/thanos/blob/main/pkg/store/bucket.go#L2514Verification
Added unit tests