rule: Add support for extended promql functions #7105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdufel
force-pushed
the
extended-func-support
branch
from
620ed12
to
fdd9be6
Compare
sdufel
changed the title
GiedriusS
reviewed
Jan 31, 2024
sdufel
force-pushed
the
extended-func-support
branch
from
fdd9be6
to
504c971
Compare
|
Sure, I just added in the changelog entry. |
yeya24
reviewed
Feb 20, 2024
Adds a flag to register the extended promql functions supported by the thanos query engine when running the rule component. This will allow rule config files containing query expressions with (xrate / xincrease / xdelta) to pass validation. This will only work if the query endpoint in use is running the thanos engine. Signed-off-by: Samuel Dufel <samuel.dufel@shopify.com>
sdufel
force-pushed
the
extended-func-support
branch
from
504c971
to
77bcd00
Compare
yeya24
approved these changes
Feb 21, 2024
GiedriusS
reviewed
Feb 22, 2024
There was a problem hiding this comment.
Docs check now failing on main https://github.com/thanos-io/thanos/actions/runs/7982085735/job/21794989282
|
Added a fix for that over here: #7161 |
GiedriusS
pushed a commit
to vinted/thanos
that referenced
this pull request
Feb 23, 2024
Adds a flag to register the extended promql functions supported by the thanos query engine when running the rule component. This will allow rule config files containing query expressions with (xrate / xincrease / xdelta) to pass validation. This will only work if the query endpoint in use is running the thanos engine. Signed-off-by: Samuel Dufel <samuel.dufel@shopify.com>
jnyi
pushed a commit
to jnyi/thanos
that referenced
this pull request
Apr 4, 2024
Adds a flag to register the extended promql functions supported by the thanos query engine when running the rule component. This will allow rule config files containing query expressions with (xrate / xincrease / xdelta) to pass validation. This will only work if the query endpoint in use is running the thanos engine. Signed-off-by: Samuel Dufel <samuel.dufel@shopify.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will add a CHANGELOG entry based on review
Changes
Adds a flag to register the extended promql functions supported by the thanos query engine when running the rule component. This will allow rule config files containing query expressions with (xrate / xincrease / xdelta) to pass validation. This will only work if the query endpoint in use is running the thanos engine.
Verification
We deployed this commit to our production environment with the flag enabled and loaded rules containing
xincrease.