*: mark as unqueryable if status is not_ready/not_healthy #7297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaHoffmann
force-pushed
the
mhoffmann/mark-sidecar-as-unqueryable-if-prometheus-is-down
branch
4 times, most recently
from
1f8c83e
to
1df444c
Compare
|
I am wondering if we can know a Prometheus is down without introducing a new field? Would be good if we can avoid indroducing a field for one component only. |
We could return an error in the info callback too, I was a bit torn between the two. |
MichaHoffmann
force-pushed
the
mhoffmann/mark-sidecar-as-unqueryable-if-prometheus-is-down
branch
from
1df444c
to
964f5f8
Compare
MichaHoffmann
changed the title
If the prometheus that belongs to a sidecar is down we dont need to query the sidecar. This PR makes it so that we take the sidecar out of the endpoint set then. We do the same for all other store APIs by retuning an error in the info/Info gRPC call if they are marked as not ready. Signed-off-by: Michael Hoffmann <mhoffm@posteo.de>
MichaHoffmann
force-pushed
the
mhoffmann/mark-sidecar-as-unqueryable-if-prometheus-is-down
branch
from
964f5f8
to
713e5e3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Added a field to Info RPC to indicate if Prometheus is down. If prometheus is down we should not fan out to the Store API of the sidecar of that prometheus.
Verification