Query: Fixing extended functions in distributed querier #7331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pedro-stanaka
force-pushed
the
fix/distributed-engine-xfunc
branch
from
6650008
to
93ca72c
Compare
|
LGTM, can you separate the prometheus import from stdlib imports though please? |
pedro-stanaka
force-pushed
the
fix/distributed-engine-xfunc
branch
from
a5d89de
to
6e87441
Compare
fpetkovski
reviewed
May 3, 2024
@MichaHoffmann can you recheck? |
pedro-stanaka
force-pushed
the
fix/distributed-engine-xfunc
branch
from
e849e05
to
76178a6
Compare
GiedriusS
reviewed
May 3, 2024
I have a follow up PR where I will clean up all other places where we use |
GiedriusS
reviewed
May 3, 2024
pkg/tenancy/tenancy_test.go
Outdated
| @@ -196,3 +195,54 @@ func TestTenantProxyPassing(t *testing.T) { | |||
| _ = q.Series(&storepb.SeriesRequest{Matchers: seriesMatchers}, &storeSeriesServer{ctx: ctx}) | |||
| }) | |||
| } | |||
|
|
|||
| func TestGetTenantFromHTTP(t *testing.T) { | |||
pedro-stanaka
force-pushed
the
fix/distributed-engine-xfunc
branch
from
f25e1bc
to
510499d
Compare
Signed-off-by: Pedro Tanaka <pedro.stanaka@gmail.com>
Signed-off-by: Pedro Tanaka <pedro.stanaka@gmail.com>
Signed-off-by: Pedro Tanaka <pedro.stanaka@gmail.com>
Signed-off-by: Pedro Tanaka <pedro.stanaka@gmail.com>
Signed-off-by: Pedro Tanaka <pedro.stanaka@gmail.com>
Signed-off-by: Pedro Tanaka <pedro.stanaka@gmail.com>
Signed-off-by: Pedro Tanaka <pedro.stanaka@gmail.com>
Signed-off-by: Pedro Tanaka <pedro.stanaka@gmail.com>
Signed-off-by: Pedro Tanaka <pedro.stanaka@gmail.com>
Signed-off-by: Pedro Tanaka <pedro.stanaka@gmail.com>
pedro-stanaka
force-pushed
the
fix/distributed-engine-xfunc
branch
from
510499d
to
7865d59
Compare
There was a problem hiding this comment.
Ah, this has been flaky for a while I think!
There was a problem hiding this comment.
That one is on me, thanks for fixing
2 tasks
Nashluffy
pushed a commit
to Nashluffy/thanos
that referenced
this pull request
May 14, 2024
* Adding repro case for broken query with distributed engine Signed-off-by: Pedro Tanaka <pedro.stanaka@gmail.com> * Fixing problem with distributed queries and xfunctios Signed-off-by: Pedro Tanaka <pedro.stanaka@gmail.com> * Adding support for extended functions in tenancy enforcement Signed-off-by: Pedro Tanaka <pedro.stanaka@gmail.com> * Moving custom parser to new package Signed-off-by: Pedro Tanaka <pedro.stanaka@gmail.com> * fixing go-lint Signed-off-by: Pedro Tanaka <pedro.stanaka@gmail.com> * Using same opts and reorganize imports Signed-off-by: Pedro Tanaka <pedro.stanaka@gmail.com> * fixing problem with query format Signed-off-by: Pedro Tanaka <pedro.stanaka@gmail.com> * fixing flaky tests Signed-off-by: Pedro Tanaka <pedro.stanaka@gmail.com> * removing extra test Signed-off-by: Pedro Tanaka <pedro.stanaka@gmail.com> * yet another flaky test Signed-off-by: Pedro Tanaka <pedro.stanaka@gmail.com> --------- Signed-off-by: Pedro Tanaka <pedro.stanaka@gmail.com> Signed-off-by: mluffman <nashluffman@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Verification
Added new acceptance tests and tested locally with two queriers.