Improved docs #840
Merged
Improved docs #840
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ker image instead of the rc. Signed-off-by: David Calvert <davidcalvertfr@gmail.com>
…vicename in order to resolve dns. Signed-off-by: David Calvert <davidcalvertfr@gmail.com>
…ay.yaml Signed-off-by: David Calvert <davidcalvertfr@gmail.com>
bwplotka
added a commit
that referenced
this pull request
Feb 22, 2019
* Removed old kube manifests with updated k8s tutorial based on demo. Signed-off-by: Bartek Plotka <bwplotka@gmail.com> * Updated kubernetes-demo manifests to use improbable/thanos:v0.3.0 docker image instead of the rc. (#827) Signed-off-by: David Calvert <davidcalvertfr@gmail.com> * Fixed links. Signed-off-by: Bartek Plotka <bwplotka@gmail.com> * Improved docs (#840) * Updated kubernetes-demo manifests to use improbable/thanos:v0.3.0 docker image instead of the rc. Signed-off-by: David Calvert <davidcalvertfr@gmail.com> * renamed thanos-gateway to thanos-store-gateway and fixed headless servicename in order to resolve dns. Signed-off-by: David Calvert <davidcalvertfr@gmail.com> * Updated docs/getting_started.md path for manifests/thanos-store-gateway.yaml Signed-off-by: David Calvert <davidcalvertfr@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
I Changed the 'thanos-querier' metadata name to match the thanos-store-gateway serviceName. It should be this way otherwise the dns will not work for 'my-sts-pod-0.my-svc-name.default.svc.cluster.local'. Tell me if you need more information about this.
I also renamed 'thanos-gateway' to 'thanos-store-gateway' as it was previously called 'thanos-store' and this could be confusing. The thanos documentation use 'thanos store gateway' so I guess it's more obvious to use it, it's just a little longer.
Verification
I have deployed theses services on GKE (Kubernetes 1.11) and noticed that dns resolution is now working as expected.