Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ran make #846

Merged
merged 2 commits into from
Feb 18, 2019
Merged

ran make #846

merged 2 commits into from
Feb 18, 2019

Conversation

domgreen
Copy link
Contributor

ran make it did some formatting of the code 👍

@domgreen domgreen self-assigned this Feb 15, 2019
Copy link
Member

@bwplotka bwplotka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just be aware that go1.10 vs go1.9 produces different formatting (:

"os"
"path"
"path/filepath"
"time"

"github.com/improbable-eng/thanos/pkg/component"

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's remove this line and run make format again.

@FUSAKLA
Copy link
Member

FUSAKLA commented Feb 17, 2019

Mmm I smell go formatting again :)
I'd at least add a note to the contribution guide with which version of golang we format the code?
Just to make things clear.

@domgreen domgreen merged commit 0ceacc9 into master Feb 18, 2019
@domgreen domgreen deleted the run_make branch February 18, 2019 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants