Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compact: relax index label checking #848

Merged
merged 1 commit into from
Mar 5, 2019

Commits on Feb 15, 2019

  1. compact: relax index label checking

    It is possible that Prometheus will produce time series with duplicate
    labels. E.g.: a{b="2",b="2"} 1
    
    Where such metric is pushed to Prometheus either wittingly or
    unwittingly, the compact process will stall because the check will not
    pass. For example:
    
    {"caller":"main.go:181","err":"error executing compaction: compaction failed: compaction: gather index issues for block /data/compact/0@{monitor="monitor",replica="repl"}/01D34EDQMSQ29RHAC47XGKHGC7: out-of-order label set {**name**="foo",exported_job="vv",host="172_16_226_56",host="172_16_226_56",region="lt",subtask_index="5",task_attempt_id="32e4b047bb768583ff57c709be3b1046",task_attempt_num="8",task_id="688c028a219ff3372f3eecb0ee5811f9",task_name="Source:_foo",tenant="abc",tier="cooltier",tm_id="53b2ed987b08f427dec4ee1465df91fa"} for series 2594231","level":"error","msg":"running command failed","ts":"2019-02-11T13:30:33.901722306Z"}
    
    This commit fixes the mentioned issue. Amend the e2e test to test the
    case when a series has identical labels.
    GiedriusS committed Feb 15, 2019
    Configuration menu
    Copy the full SHA
    bccfdcc View commit details
    Browse the repository at this point in the history