Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vendor: update TSDB and Prometheus #85

Merged
merged 1 commit into from
Nov 24, 2017
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 18 additions & 6 deletions Gopkg.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion Gopkg.toml
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@
name = "github.com/grpc-ecosystem/go-grpc-prometheus"

[[constraint]]
branch = "fabxc"
branch = "master"
name = "github.com/prometheus/tsdb"

[[constraint]]
Expand Down
6 changes: 5 additions & 1 deletion pkg/query/api/v1.go
Original file line number Diff line number Diff line change
Expand Up @@ -336,7 +336,11 @@ func (api *API) series(r *http.Request) (interface{}, *apiError) {
var set storage.SeriesSet

for _, mset := range matcherSets {
set = storage.DeduplicateSeriesSet(set, q.Select(mset...))
s, err := q.Select(mset...)
if err != nil {
return nil, &apiError{errorExec, err}
}
set = storage.DeduplicateSeriesSet(set, s)
}

metrics := []labels.Labels{}
Expand Down
10 changes: 5 additions & 5 deletions pkg/query/querier.go
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,7 @@ func storeMatches(s StoreInfo, matchers ...*labels.Matcher) bool {
return true
}

func (q *querier) Select(ms ...*labels.Matcher) storage.SeriesSet {
func (q *querier) Select(ms ...*labels.Matcher) (storage.SeriesSet, error) {
var (
mtx sync.Mutex
all []storepb.SeriesSet
Expand All @@ -134,7 +134,7 @@ func (q *querier) Select(ms ...*labels.Matcher) storage.SeriesSet {

sms, err := translateMatchers(ms...)
if err != nil {
return promSeriesSet{set: errSeriesSet{err: err}}
return nil, errors.Wrap(err, "convert matchers")
}
for _, s := range q.stores {
// We might be able to skip the store if its meta information indicates
Expand All @@ -157,7 +157,7 @@ func (q *querier) Select(ms ...*labels.Matcher) storage.SeriesSet {
})
}
if err := g.Wait(); err != nil {
return promSeriesSet{set: errSeriesSet{err: err}}
return nil, errors.Wrap(err, "query stores")
}
set := promSeriesSet{
mint: q.mint,
Expand All @@ -168,9 +168,9 @@ func (q *querier) Select(ms ...*labels.Matcher) storage.SeriesSet {
// of the same series into a single one. The series are ordered so that equal series
// from different replicas are sequential. We can now deduplicate those.
if q.replicaLabel == "" {
return set
return set, nil
}
return newDedupSeriesSet(set, q.replicaLabel)
return newDedupSeriesSet(set, q.replicaLabel), nil
}

func (q *querier) selectSingle(client storepb.StoreClient, ms ...storepb.LabelMatcher) (storepb.SeriesSet, error) {
Expand Down
3 changes: 2 additions & 1 deletion pkg/query/querier_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,8 @@ func TestQuerier_Series(t *testing.T) {
}, 1, 300, "")
defer q.Close()

res := q.Select()
res, err := q.Select()
testutil.Ok(t, err)

expected := []struct {
lset labels.Labels
Expand Down