compact: add concurrency to meta sync #887
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjd95
commented
Mar 5, 2019
added 2 commits
March 5, 2019 14:44
bwplotka
approved these changes
Mar 5, 2019
cmd/thanos/compact.go
Outdated
| @@ -92,6 +92,9 @@ func registerCompact(m map[string]setupFunc, app *kingpin.Application, name stri | |||
| maxCompactionLevel := cmd.Flag("debug.max-compaction-level", fmt.Sprintf("Maximum compaction level, default is %d: %s", compactions.maxLevel(), compactions.String())). | |||
| Hidden().Default(strconv.Itoa(compactions.maxLevel())).Int() | |||
|
|
|||
| metaSyncConcurrency := cmd.Flag("meta-sync-concurrency", "Number of goroutines to use when syncing metadata from object storage."). | |||
There was a problem hiding this comment.
I would be consistent with store gateway flag here as it is essentially the same thing.
Suggested change
| metaSyncConcurrency := cmd.Flag("meta-sync-concurrency", "Number of goroutines to use when syncing metadata from object storage."). | |
| metaSyncConcurrency := cmd.Flag("block-sync-concurrency", "Number of goroutines to use when syncing block metadata from object storage."). |
cmd/thanos/compact.go
Outdated
| @@ -92,6 +92,9 @@ func registerCompact(m map[string]setupFunc, app *kingpin.Application, name stri | |||
| maxCompactionLevel := cmd.Flag("debug.max-compaction-level", fmt.Sprintf("Maximum compaction level, default is %d: %s", compactions.maxLevel(), compactions.String())). | |||
| Hidden().Default(strconv.Itoa(compactions.maxLevel())).Int() | |||
|
|
|||
| metaSyncConcurrency := cmd.Flag("meta-sync-concurrency", "Number of goroutines to use when syncing metadata from object storage."). | |||
| Default("1").Int() | |||
There was a problem hiding this comment.
We can actually make it faster by default to some reasonable number like 20. (same as store gateway). There is no reason, NOT to.
cmd/thanos/compact.go
Outdated
| @@ -108,6 +111,7 @@ func registerCompact(m map[string]setupFunc, app *kingpin.Application, name stri | |||
| name, | |||
| *disableDownsampling, | |||
| *maxCompactionLevel, | |||
| *metaSyncConcurrency, | |||
There was a problem hiding this comment.
let's change var name as well to follow up flag name
bwplotka
approved these changes
Mar 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Add a flag to the
compactcommand to allow for fetching of the block metadata in parallel.Verification
Tested by running
thanos compactwith--log.level=debugto see that it fetches the metadata much quicker when concurrency is added.