query: support POST method for query/query_range endpoints #939
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joseph Lee <joseph.t.lee@outlook.com>
GiedriusS
approved these changes
Mar 19, 2019
There was a problem hiding this comment.
Thank you very much for your contribution! Now Thanos Query is closer to having the same Prometheus API as outlined here: https://github.com/prometheus/prometheus/blob/5603b857a9182ea3129dce023b4ee5eed31a5f4e/web/api/v1/api.go#L224.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Joseph Lee joseph.t.lee@outlook.com
Changes
The Prometheus support POST method for
query/query_rangeendpoints, and Grafana support POST method for Prometheus too.When do complex query with multi label values from Grafana used GET method such as
count(node_load{instance=~"11\\.11\\.11\\.11|\\8\\.8\\.8\\.8"})that labelinstancehave much more IP will failed, but if support POST method in Thanos Query, the query will work.Verification
I have test it in my daily environment and production environment.