Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve composer files #1

Merged
merged 4 commits into from Nov 12, 2018
Merged

Conversation

gmponos
Copy link
Contributor

@gmponos gmponos commented Nov 10, 2018

  • Removed composer.lock file. In general you will notice that packages do not submit composer.lock file. Check symfonys package for example.
  • Running composer validate shows some errors
The lock file is not up to date with the latest changes in composer.json, it is recommended that you run `composer update`.
  • Added keywords.
  • Added license
  • Require a minimum PHP version inside the package since it can be easily overridden.

Please also consider the following:

Rename the composer name to: thanos-kontos/greek-validators-symfony inside the composer.json it is as thanosKontos/greek-validators-symfony

From composer validate:

Name "thanosKontos/greek-validators-symfony" does not match the best practice (e.g. lower-cased/with-dashes). We suggest using "thanos-kontos/greek-validators-symfony" instead. As such you will not be able to submit it to Packagist.

@gmponos gmponos changed the title Remove composer.lock Improve composer files Nov 10, 2018
@thanosKontos thanosKontos merged commit 7dddc76 into thanosKontos:master Nov 12, 2018
@gmponos gmponos deleted the gmponos-patch-1 branch November 12, 2018 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants