Skip to content
This repository has been archived by the owner on Apr 4, 2024. It is now read-only.

make jsonrpc api namespaces extensible #1056

Merged
merged 3 commits into from
Apr 19, 2022
Merged

Conversation

yihuang
Copy link
Contributor

@yihuang yihuang commented Apr 19, 2022

Description

Closes: #1052, #1037

An example of usage: https://github.com/crypto-org-chain/cronos/pull/432/files#diff-7acb7332ad576a49e7685db72282959006f156c06a708828d8b0b187e311ffe1R32


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

Copy link
Contributor

@fedekunze fedekunze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the approach but ideally you shouldn't be able to override existing namespaces, just add new ones. Can you update the implementation to support that?

rpc/apis.go Outdated Show resolved Hide resolved
@yihuang
Copy link
Contributor Author

yihuang commented Apr 19, 2022

I like the approach but ideally you shouldn't be able to override existing namespaces, just add new ones. Can you update the implementation to support that?

good idea, added a method to register extra namespace.

Copy link
Contributor

@fedekunze fedekunze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK, minor comments

rpc/apis.go Outdated Show resolved Hide resolved
rpc/apis.go Outdated Show resolved Hide resolved
rpc/apis.go Outdated Show resolved Hide resolved
@fedekunze fedekunze enabled auto-merge (squash) April 19, 2022 12:39
@fedekunze fedekunze merged commit 0543a28 into evmos:main Apr 19, 2022
@yihuang yihuang deleted the ext-rpc branch April 20, 2022 01:06
yihuang added a commit to yihuang/ethermint that referenced this pull request Apr 20, 2022
* make jsonrpc api namespaces extensible

Closes: evmos#1052, evmos#1037

* Apply suggestions from code review

Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com>
yihuang added a commit to yihuang/ethermint that referenced this pull request Apr 27, 2022
* make jsonrpc api namespaces extensible

Closes: evmos#1052, evmos#1037

* Apply suggestions from code review

Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Need an api to recover execution result from the false-failed tx
3 participants