This repository has been archived by the owner on Apr 4, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 561
make jsonrpc api namespaces extensible #1056
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yihuang
requested review from
fedekunze,
khoslaventures and
jolube
as code owners
April 19, 2022 04:19
11 tasks
fedekunze
reviewed
Apr 19, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the approach but ideally you shouldn't be able to override existing namespaces, just add new ones. Can you update the implementation to support that?
crypto-facs
reviewed
Apr 19, 2022
good idea, added a method to register extra namespace. |
fedekunze
approved these changes
Apr 19, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK, minor comments
yihuang
added a commit
to yihuang/ethermint
that referenced
this pull request
Apr 20, 2022
* make jsonrpc api namespaces extensible Closes: evmos#1052, evmos#1037 * Apply suggestions from code review Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com>
yihuang
added a commit
to yihuang/ethermint
that referenced
this pull request
Apr 27, 2022
* make jsonrpc api namespaces extensible Closes: evmos#1052, evmos#1037 * Apply suggestions from code review Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes: #1052, #1037
An example of usage: https://github.com/crypto-org-chain/cronos/pull/432/files#diff-7acb7332ad576a49e7685db72282959006f156c06a708828d8b0b187e311ffe1R32
For contributor use:
docs/
) or specification (x/<module>/spec/
)godoc
comments.Unreleased
section inCHANGELOG.md
Files changed
in the Github PR explorerFor admin use:
WIP
,R4R
,docs
, etc)