imp: enable revive rules

[fedekunze]

Description

I have set all severity: error flags to a warning.
This in the meantime will enable us to tackle each of the lint issues in individual PRs.

Closes: #XXX

---

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

PR review checkboxes:

I have...

• added a relevant changelog entry to the Unreleased section in CHANGELOG.md
• included the correct type prefix in the PR title
• targeted the correct branch (see PR Targeting)
• provided a link in the PR description to the relevant issue or specification
• reviewed "Files changed" and left comments if necessary
• confirmed all required CI checks have passed

Code maintenance:

I have...

• written unit and integration tests
• added relevant godoc and code comments.
• updated relevant documentation (docs/) or specification (x/<module>/spec/)

---

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add your handle next to the items reviewed if you only reviewed selected items.

I have...

• confirmed the correct type prefix in the PR title
• confirmed all author checklist items have been addressed
• confirmed that this PR does not change production code

[codecov]

Codecov Report

Merging #400 (cb108ea) into main (7649ee0) will increase coverage by 0.07%.
The diff coverage is 98.63%.

@@            Coverage Diff             @@
##             main     #400      +/-   ##
==========================================
+ Coverage   82.57%   82.64%   +0.07%     
==========================================
  Files         122      122              
  Lines        6885     6914      +29     
==========================================
+ Hits         5685     5714      +29     
  Misses       1055     1055              
  Partials      145      145              

Impacted Files	Coverage Δ
x/erc20/types/proposal.go	91.46% <50.00%> (ø)
x/claims/keeper/ibc_callbacks.go	97.76% <100.00%> (ø)
x/epochs/keeper/abci.go	100.00% <100.00%> (ø)
x/epochs/types/identifier.go	100.00% <100.00%> (ø)
x/erc20/keeper/evm.go	92.15% <100.00%> (ø)
x/erc20/types/token_pair.go	100.00% <100.00%> (ø)
x/incentives/keeper/gas_meters.go	97.10% <100.00%> (ø)
x/inflation/types/params.go	88.57% <100.00%> (-0.32%)	⬇️
x/vesting/keeper/msg_server.go	91.50% <100.00%> (+1.29%)	⬆️
x/vesting/types/clawback_vesting_account.go	96.77% <100.00%> (+0.02%)	⬆️
... and 1 more

[Prosp3r]

Changes look good.
Just some questions for understanding.

[fedekunze]

Thanks @Prosp3r for the review. Can you take over this PR to fix the linter that is currently failing because of all the new rules?

[Prosp3r]

I have set all severity: error flags to a warning.
This in the meantime will enable us to tackle each of the lint issues in individual PRs.

[lgtm-com]

This pull request introduces 13 alerts when merging 25e5fcc into ffff90c - view on LGTM.com

new alerts:

• 9 for Useless assignment to local variable
• 4 for Unreachable statement

[lgtm-com]

This pull request introduces 13 alerts when merging 745d14a into d29dd33 - view on LGTM.com

new alerts:

• 9 for Useless assignment to local variable
• 4 for Unreachable statement

[danburck]

LGTM, @Prosp3r can you add a changelog and resolve the open conversations?

[fedekunze]

linter needs to be fixed too

[lgtm-com]

This pull request fixes 1 alert when merging 0b0abbb into 150082f - view on LGTM.com

fixed alerts:

• 1 for Useless assignment to local variable

[lgtm-com]

This pull request fixes 1 alert when merging 97cdf72 into 150082f - view on LGTM.com

fixed alerts:

• 1 for Useless assignment to local variable

[lgtm-com]

This pull request fixes 1 alert when merging a8d35b3 into 150082f - view on LGTM.com

fixed alerts:

• 1 for Useless assignment to local variable

[lgtm-com]

This pull request fixes 1 alert when merging 833e05f into 150082f - view on LGTM.com

fixed alerts:

• 1 for Useless assignment to local variable

[lgtm-com]

This pull request fixes 1 alert when merging 563a5cb into 150082f - view on LGTM.com

fixed alerts:

• 1 for Useless assignment to local variable

[lgtm-com]

This pull request fixes 1 alert when merging d595bb6 into 150082f - view on LGTM.com

fixed alerts:

• 1 for Useless assignment to local variable

[lgtm-com]

This pull request fixes 1 alert when merging 71c5161 into 8d53902 - view on LGTM.com

fixed alerts:

• 1 for Useless assignment to local variable

[lgtm-com]

This pull request fixes 1 alert when merging 485d71a into 8d53902 - view on LGTM.com

fixed alerts:

• 1 for Useless assignment to local variable

[fedekunze]

@Prosp3r have you looked into the severity configuration and GitHub Actions output format?

[lgtm-com]

This pull request fixes 1 alert when merging cb108ea into 7649ee0 - view on LGTM.com

fixed alerts:

• 1 for Useless assignment to local variable

[danburck]

Closing for now. Please reopen if it's being worked on