impr(inflation): Rename total supply endpoint
#536
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ENG-207 Rename /evmos/inflation/v1/total_supply -> /evmos/inflation/v1/circulating_supply
This is a breaking change so we will need to inform partners that this will change. This clarifies what the difference is between querying total supply on |
Codecov Report
@@ Coverage Diff @@
## main #536 +/- ##
=======================================
Coverage 81.56% 81.56%
=======================================
Files 115 115
Lines 6375 6375
=======================================
Hits 5200 5200
Misses 1018 1018
Partials 157 157
|
danburck
changed the title
danburck
changed the title
inflation): Rename total supply endpoint
danburck
requested review from
hanchon,
ramacarlucho,
fedekunze,
khoslaventures and
jolube
as code owners
fedekunze
reviewed
Apr 28, 2022
This happened when running |
fedekunze
reviewed
Apr 29, 2022
fedekunze
approved these changes
Apr 29, 2022
what version of |
loredanacirstea
added a commit
to loredanacirstea/evmos
that referenced
this pull request
May 6, 2022
* loredana/ENG-214-add-epoch-types: (40 commits) Update evmos v3 -> v4 after latest changes Add year and hour epochs Update evmos v3 -> v4 after latest changes uncomment check feat: Inbound / outbound peers & default seeds (evmos#541) upgrade: Update Evmos go.mod version `v3` -> `v4` (evmos#557) Add change log Add migration logic for epoch change Fix epochs unit tests Revert to ascending order Store epoch information by duration and by identifier audit(erc20): add types tests and update comments (evmos#550) [ENG-219] bump erc20 test coverage (evmos#546) audit(erc20): state machine audit (evmos#547) audit(erc20): Changes from api audit (evmos#544) imp: update default min-gas-prices (evmos#543) imp: use constants for epochs IDs (evmos#539) fix: upgrade client router key (evmos#537) impr(`inflation`): Rename total supply endpoint (evmos#536) fix: `buf protoc` was moved to `buf alpha protoc` (evmos#462) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR renames the endpoint
/evmos/inflation/v1/total_supplyto/evmos/inflation/v1/circulating_supplyto avoid confusion with thetotalSupplyfrom the bank module. The circulating supply excludes the team vesting allocation in the first year.Note that this is a state machine breaking change.