fees: limit address derivation to 20 iterations at registration #603
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loredanacirstea
requested review from
fedekunze,
khoslaventures and
jolube
as code owners
Codecov Report
@@ Coverage Diff @@
## main #603 +/- ##
=======================================
Coverage 83.32% 83.32%
=======================================
Files 116 116
Lines 6373 6376 +3
=======================================
+ Hits 5310 5313 +3
Misses 935 935
Partials 128 128
|
fedekunze
approved these changes
May 12, 2022
loredanacirstea
added a commit
that referenced
this pull request
May 14, 2022
* main: Correct inflation.proto typo (#608) change algolia search key (#607) Changing erroneous epoch skips to daily instead of weekly (#554) fix: remove dup set claims record + CLI update (#605) build(deps): bump github.com/spf13/cast from 1.4.1 to 1.5.0 (#604) imp: fees test coverage (#586) fees: limit address derivation to 20 iterations at registration (#603)
loredanacirstea
added a commit
to loredanacirstea/evmos
that referenced
this pull request
May 16, 2022
* main: Correct inflation.proto typo (evmos#608) change algolia search key (evmos#607) Changing erroneous epoch skips to daily instead of weekly (evmos#554) fix: remove dup set claims record + CLI update (evmos#605) build(deps): bump github.com/spf13/cast from 1.4.1 to 1.5.0 (evmos#604) imp: fees test coverage (evmos#586) fees: limit address derivation to 20 iterations at registration (evmos#603)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We already charge gas for address derivation. But I am also adding the second limitation suggested here #436 (review)
Closes: #XXX
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
PR review checkboxes:
I have...
Unreleasedsection inCHANGELOG.mdCode maintenance:
I have...
godocand code comments.docs/) or specification (x/<module>/spec/)Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add your handle next to the items reviewed if you only reviewed selected items.
I have...