Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Transfer usage restructuring and D3D11 async readback #42

Merged
merged 9 commits into from
Jun 19, 2024
Merged

Transfer usage restructuring and D3D11 async readback #42

merged 9 commits into from
Jun 19, 2024

Conversation

thatcosmonaut
Copy link
Owner

Found a workaround for D3D11, so these types are no longer needed.

flibitijibibo
flibitijibibo reviewed Jun 18, 2024
View reviewed changes
Copy link
Collaborator

@flibitijibibo flibitijibibo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me; for the purposes of the PR we should link back to the review/feedback that this addresses.

@thatcosmonaut
Copy link
Owner Author

Fixes #44

flibitijibibo
flibitijibibo approved these changes Jun 18, 2024
View reviewed changes
Copy link
Collaborator

@flibitijibibo flibitijibibo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be fine once CI is happy

@flibitijibibo flibitijibibo mentioned this pull request Jun 18, 2024
Draft
@thatcosmonaut thatcosmonaut changed the title Remove transfer usage and transfer map flags Transfer usage restructuring and D3D11 async readback Jun 19, 2024
@thatcosmonaut thatcosmonaut merged commit d7597d5 into gpu Jun 19, 2024
78 checks passed
@thatcosmonaut thatcosmonaut deleted the remove_transfer_type branch June 19, 2024 00:50
flibitijibibo pushed a commit that referenced this pull request Jun 21, 2024
@thatcosmonaut @flibitijibibo
Transfer usage restructuring and D3D11 async readback (#42)
eb934db
flibitijibibo pushed a commit that referenced this pull request Jun 28, 2024
@thatcosmonaut @flibitijibibo
Transfer usage restructuring and D3D11 async readback (#42)
6b92690
bartwe pushed a commit to bartwe/SDL-gpu-dx12 that referenced this pull request Jul 6, 2024
@thatcosmonaut @flibitijibibo
Transfer usage restructuring and D3D11 async readback (thatcosmonaut#42)
ea093f5
flibitijibibo pushed a commit that referenced this pull request Jul 11, 2024
@thatcosmonaut @flibitijibibo
Transfer usage restructuring and D3D11 async readback (#42)
db1d9f4
bartwe pushed a commit to bartwe/SDL-gpu-dx12 that referenced this pull request Jul 12, 2024
@thatcosmonaut @flibitijibibo
Transfer usage restructuring and D3D11 async readback (thatcosmonaut#42)
c80cf86
bartwe pushed a commit to bartwe/SDL-gpu-dx12 that referenced this pull request Jul 13, 2024
@thatcosmonaut @flibitijibibo
Transfer usage restructuring and D3D11 async readback (thatcosmonaut#42)
89ed3e8
flibitijibibo pushed a commit that referenced this pull request Jul 16, 2024
@thatcosmonaut @flibitijibibo
Transfer usage restructuring and D3D11 async readback (#42)
2395971
flibitijibibo pushed a commit that referenced this pull request Jul 19, 2024
@thatcosmonaut @flibitijibibo
Transfer usage restructuring and D3D11 async readback (#42)
ed5f86e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flibitijibibo flibitijibibo flibitijibibo approved these changes

@TheSpydog TheSpydog TheSpydog approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@thatcosmonaut @flibitijibibo @TheSpydog