Texture format swizzling #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flibitijibibo
approved these changes
Jul 4, 2024
Marked this one as ready for now since I believe this is just a quick MTLTextureSwizzle, but if it's a major blocker that can be reverted (otherwise I'll apply this to the weekly update). |
bartwe
pushed a commit
to bartwe/SDL-gpu-dx12
that referenced
this pull request
Jul 6, 2024
flibitijibibo
pushed a commit
that referenced
this pull request
Jul 11, 2024
bartwe
pushed a commit
to bartwe/SDL-gpu-dx12
that referenced
this pull request
Jul 12, 2024
bartwe
pushed a commit
to bartwe/SDL-gpu-dx12
that referenced
this pull request
Jul 13, 2024
flibitijibibo
pushed a commit
that referenced
this pull request
Jul 16, 2024
flibitijibibo
pushed a commit
that referenced
this pull request
Jul 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #56.
Replaces:
R5G6B5->B5G6R5A1R5G5B5->B5G5R5A1A2R10G10B10->R10G10B10A2and removes
A2B10G10R10entirely.The reason for the last change is because I was incorrect in my initial write-up, D3D11/12 have no support for
B10G10R10A2. So we'd have to swizzleR10G10B10A2on the D3D side, which is not ideal. To keep as much swizzling logic as possible in Vulkan, I think we should exclusively offer RGBA order.However, Vulkan's native surface support for
A2R10G10B10is ~12%. So instead we'll always useA2B10R10G10(which has a ~62% surface support rate) and then swizzle it into RGBA order.One remaining issue is with Metal's
ABGR4format. It doesn't supportBGRA4or any other swizzle natively, and D3D/VK don't supportA4B4G4R4natively. I'll need to set up a Metal swizzle for this format specifically.