Update README.md to put emphasis the possibility to supply arguments offered by client providers. #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…offered by client providers. I was considering making a pr to share my addition to support the "hostedDomain" argument for google oauth when I finally read and understood the phrase stating "Each array entry is used as the configuration option to a new OAauth Provider Class instance so all options which are documented for the selected OAuth Provider class are available." Stupid of me of course, but I think that expanding the example given does not unnecessarily complicate things, and that it may spare some future user of thus plugin the time it took me to realise this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was considering making a pr to share my addition to support the "hostedDomain" argument for Google OAuth when I finally read and understood the phrase stating "Each array entry is used as the configuration option to a new OAauth Provider Class instance so all options which are documented for the selected OAuth Provider class are available."
Stupid of me of course, but I think that expanding the example given does not unnecessarily complicate things, and that it may spare some future user of this plugin the time it took me to realise this.
Oh, and I standardised the capitalisation and comment spacing in that code block