Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Default font doesn't support japanese characters #454

Closed
3 tasks done
Lolirag opened this issue May 16, 2024 · 6 comments
Closed
3 tasks done

[Bug]: Default font doesn't support japanese characters #454

Lolirag opened this issue May 16, 2024 · 6 comments
Labels
bug Something isn't working

Comments

@Lolirag
Copy link

Lolirag commented May 16, 2024

Preflight checklist

  • I have searched the issue tracker for a bug report that matches the one I want to file, without success.
  • I have searched the frequently asked questions for a solution that fixes this problem, without success.
  • I have checked that I'm using the latest stable version of the app.

What app version are you using?

v5.1.0

What operating system version are you using?

Windows

Expected Behavior

When inputting external subtitles, the Japanese Text would display properly.
(I expect Japanese to be supported, given the Preferred Subtitled Language setting.)

Actual Behavior

Instead, all the characters are errors.

Having tested various different subtitles with various series, external subtitles of the romance language have no issue. Japanese however, does.
Have also tested on other media players, and they expectedly display without issue.

Screenshots

Miru_FTQXrzABVE
Miru_i7G6vNyTP2

@Lolirag Lolirag added the bug Something isn't working label May 16, 2024
@ThaUnknown
Copy link
Owner

the default fallback font in miru doesn't support japanese characters, you'll need to install a font on your PC that does, then set that as default fallback font in settings

@Lolirag
Copy link
Author

Lolirag commented May 17, 2024

It seems I'm retarded. Thanks.

@ThaUnknown
Copy link
Owner

nah, I considered making a font that supports jp sub

@ThaUnknown ThaUnknown changed the title [Bug]: External Japanese Subtitles Errors [Bug]: Default font doesn't support japanese characters May 17, 2024
@dfireBird
Copy link

dfireBird commented Jun 12, 2024

I tried changing the default subtitle font to 'Noto Sans CJK JP' but I get the error in screenshot.
image

@ThaUnknown
Copy link
Owner

huh, cool

@ThaUnknown
Copy link
Owner

@dfireBird this is fixed in 5.1.2 33f9124

there's not an easy to fix this, however the solution is "use a fallback font which has japanese characters", but if the release includes a font, which doesnt support jp characters, then proceeds to create fonts which have jp chars, this wont work, so i'm gonna track this issue in #329

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants