Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor naming issue #3

Open
ice1000 opened this issue Aug 31, 2018 · 3 comments
Open

Minor naming issue #3

ice1000 opened this issue Aug 31, 2018 · 3 comments
Assignees
Labels
question Further information is requested

Comments

@ice1000
Copy link
Collaborator

ice1000 commented Aug 31, 2018

Just pulled and saw

 rename RBNF/Core/{CachingPool.fs => caching_pool.fs} (100%)

Why? All other files are named with PascalCase.

@ice1000 ice1000 added enhancement New feature or request question Further information is requested and removed enhancement New feature or request labels Aug 31, 2018
@thautwarm
Copy link
Owner

There is a long history for people who use ocaml to use underscores for filenames, however it's not a standard rule.

See ocaml style guide.

I think the underscore is something very ocaml, take care that we should avoid to write F# in Java/C# style.

@ice1000
Copy link
Collaborator Author

ice1000 commented Sep 1, 2018

So you're bringing inconsistency here. We should always follow the same convention, so do you mean we should rename all the files into snake case?

@thautwarm
Copy link
Owner

As a module name should be PascalCase, and a file just maps to a module in F# style(when no namespace occurs), we could use PascalCase. Feel free to rename them all...
Nighty night!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants