-
Notifications
You must be signed in to change notification settings - Fork 641
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Question about the status code in the rule #221
Comments
Agree but it requires a lot of efforts to fix. lol |
@tbrand I can do it ... question is to write rules that cover all use cases (what about https://www.techempower.com/benchmarks/) |
Rules are good, the more detailed the better. Like not just saying things like GET and 204 with empty body or so, but even more detailed so that the implementations remain good comparisons, things like routing must be performed a certain way or validation must be done on x-and-x, etc... |
@tbrand @OvermindDL1 digging for any benchmarks, and how developers use it / implement it What do you think about that ? I think it COULD be helpful to decrease our rule set to only one endpoint implementation, for example, it could be a The advantage I see :
|
I'd think multiple routes are fine as there tend to be many in any given application and they are generally only another line of code in most of them anyway. Plus keeping them separate allows you to benchmark the different parts and handling of a framework as well. |
In the rules section it says:
As per HTTP standard, empty body should have a 204 response, and POST success normally indicates a create success, thus it might be good to return 201 Created.
The text was updated successfully, but these errors were encountered: