Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hapi (Node) #233

Closed
waghanza opened this issue Jun 6, 2018 · 10 comments
Closed

Add hapi (Node) #233

waghanza opened this issue Jun 6, 2018 · 10 comments

Comments

@waghanza
Copy link
Collaborator

waghanza commented Jun 6, 2018

https://github.com/hapijs/hapi

@waghanza waghanza mentioned this issue Jul 4, 2018
@armand1m
Copy link

armand1m commented Jul 26, 2018

@waghanza great work mate! I see the PR is merged but no docs were added, nor a place in the benchmarks. These would be extremely helpful as well =)

@aichholzer
Copy link
Member

Isn't Hapi like the slowest framework around?

@armand1m
Copy link

@aichholzer that is the point =)

@waghanza
Copy link
Collaborator Author

@armand1m Thanks. Good catch ;-)

due to intense work 😛 hapi has been dropped (unintentionally)

hapi will be added to the next release

@aichholzer We will see ... the next release will no be production-ready, the next after will (but I do not know when I will have the time to do so)

PS : Some previous results

Language (Runtime) Framework (Middleware) Requests / s Throughput
node fastify 61358.00 91.68 MB
node polka 52718.00 78.61 MB
node rayo 47574.00 71.10 MB
node koa 36394.00 76.90 MB
node express 33598.00 82.17 MB
node restify 34149.00 59.80 MB
node hapi 29352.00 54.91 MB

@aichholzer
Copy link
Member

How did Fastify get almost 10K req/s ahead of the rest? - Does not seem to be realistic.

@aichholzer
Copy link
Member

If you are running on a multi-core server, then you should enable @rayo/storm in the latest version of rayo.

It will increase it's performance (and throughput) by almost 200% percent, hence blowing the socks off the other contenders, although it will probably not be a fair competition... 🙈

@waghanza
Copy link
Collaborator Author

waghanza commented Jul 27, 2018

@aichholzer 😛 I'm sure you'll be impatient to compete ^^

Feel free to PR usage for @rayo/storm. I'll be glad to merge

PS : All benchmarks are using PM2, it could be changed ... I'm not so skilled in node

@aichholzer
Copy link
Member

PM2 will run on multi-cores if enabled and if the server supports it. I will try to get a PR across. Still curious on Fastify's performance gains.

@waghanza
Copy link
Collaborator Author

@aichholzer sending those result was a (gentle) provocation 😛.

Above results are garbage / draft

@aichholzer
Copy link
Member

🤣
Well done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants