Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JavaScript] Add Astro #6029

Closed
RoadRoller01 opened this issue Jan 1, 2023 · 5 comments
Closed

[JavaScript] Add Astro #6029

RoadRoller01 opened this issue Jan 1, 2023 · 5 comments

Comments

@RoadRoller01
Copy link

Astro website

@RoadRoller01
Copy link
Author

Hi @RoadRoller01,

Feel free to open a PR then ❤️

We (mostly me) could take care of any implementation in here.

If you want to make a PR, you should implement Astro (in javascript folder) with the following :

  • GET /, SHOULD return a successful status code and an empty string
  • GET /user/:id, SHOULD return a successful status code and the id
  • POST /user, SHOULD return a successful status code and an empty string

Regards,

@waghanza you were late by two steps

@waghanza
Copy link
Collaborator

waghanza commented Jan 1, 2023

You answered your own issue @RoadRoller01 😛 anyway thanks for your interest in this project

As you say, feel free to open a PR, I'll review it

Btw, to include it here you will ne explicit approval from any core contributor (cc @FredKSchott @matthewp @natemoo-re) or wait for 10 days if no answer (and no opposition to include astro here)

Regards,

@ghost
Copy link

ghost commented May 14, 2023

How about rebuiling benchmark results chart with Astro and add to showcase instead? It's exactly what Astro is designed for, start with 0KB of JavaScript.
https://astro.build/showcase/

@waghanza
Copy link
Collaborator

Not sure it is the same subject @RoadRoller01. The website charts are built on https://github.com/the-benchmarker/website but @SuspiciousLookingOwl is working on it, feel free to join forces ❤️

But maybe benchmarking api with astro is an other topic

@RoadRoller01
Copy link
Author

aaa i think i will close this issue, i lost the interest to astro.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants