Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added navbar #20

Merged
merged 4 commits into from Jan 5, 2022
Merged

Added navbar #20

merged 4 commits into from Jan 5, 2022

Conversation

artimanputra
Copy link
Contributor

I have added a navbar. See screenshot here

@subhangi2731
Copy link
Collaborator

@artimanputra can you please upload the screenshot here

@artimanputra
Copy link
Contributor Author

@artimanputra can you please upload the screenshot here
Screenshot (193)

@adityabisoi
Copy link
Contributor

Can you check loading your extension once? It looks like this
Screenshot from 2021-12-08 09-21-35

@artimanputra
Copy link
Contributor Author

Can you check loading your extension once? It looks like this Screenshot from 2021-12-08 09-21-35

U7BXMV2HWy.mp4

It is like this on my PC

@subhangi2731
Copy link
Collaborator

@artimanputra Can you put different colours in navbar and body?

@artimanputra
Copy link
Contributor Author

@artimanputra Can you put different colors in navbar and body?

Yup. Let me know which colour will work? Shall I use dark colours?

@subhangi2731
Copy link
Collaborator

subhangi2731 commented Dec 8, 2021

@artimanputra You can use grey color in the whole navbar also make the color hover on the links in the navbar(text) so that when you keep the mouse pointer and select it shows a different color and when you don't select it shows the normal navbar color. Keep the text color normally as grey but when selecting it as blue as you have kept it now

@artimanputra
Copy link
Contributor Author

@artimanputra You can use grey color in the whole navbar also make the color hover on the links in the navbar(text) so that when you keep the mouse pointer and select it shows a different color and when you don't select it shows the normal navbar color. Keep the text color normally as grey but when selecting it as blue as you have kept it now

okay

@artimanputra
Copy link
Contributor Author

artimanputra commented Dec 8, 2021

@artimanputra You can use grey color in the whole navbar also make the color hover on the links in the navbar(text) so that when you keep the mouse pointer and select it shows a different color and when you don't select it shows the normal navbar color. Keep the text color normally as grey but when selecting it as blue as you have kept it now

Checkout This

YphAQZc4K1.mp4

@adityabisoi
Copy link
Contributor

@artimanputra Did you load the extension?

@artimanputra
Copy link
Contributor Author

@artimanputra Did you load the extension?

Yes

@subhangi2731
Copy link
Collaborator

@artimanputra Great. Just one thing the area where you have written save notes text don't keep that part grey you can keep that blue just keep the navbar part grey where you have the links

@artimanputra
Copy link
Contributor Author

artimanputra commented Dec 8, 2021

@artimanputra Great. Just one thing the area where you have written save notes text don't keep that part grey you can keep that blue just keep the navbar part grey where you have the links

@subhangi2731 Okay, check this once . @adityabisoi
chrome_O3V3oN3qsx

@subhangi2731
Copy link
Collaborator

@artimanputra The extension doesn't load for me too

@artimanputra
Copy link
Contributor Author

@artimanputra The extension doesn't load for me too

okay will check once again

@adityabisoi
Copy link
Contributor

@artimanputra Instead of opening the HTML page on a browser, try loading the extension following steps mentioned in README, then open the extension to see how your changes look.

@artimanputra
Copy link
Contributor Author

@artimanputra Instead of opening the HTML page on a browser, try loading the extension following steps mentioned in README, then open the extension to see how your changes look.

Okay

@adityabisoi
Copy link
Contributor

@artimanputra Any updates on this?

@subhangi2731
Copy link
Collaborator

Hi @artimanputra Do you need some help on this?

@artimanputra
Copy link
Contributor Author

Hi @artimanputra Do you need some help on this?

Yeah, I am getting a lot of errors when I am trying to set up it locally. I have sent those screenshots on gitter.

@adityabisoi
Copy link
Contributor

@artimanputra Since your queries in Gitter have been cleared now, can you provide updates on this issue?

@artimanputra
Copy link
Contributor Author

@artimanputra Since your queries in Gitter have been cleared now, can you provide updates on this issue?

@adityabisoi yup I am on that, just tell me Shall I create a new component for the header? and one more thing there is no app.js or index.js so in which should I import it?

@adityabisoi
Copy link
Contributor

@artimanputra Since your queries in Gitter have been cleared now, can you provide updates on this issue?

@adityabisoi yup I am on that, just tell me Shall I create a new component for the header? and one more thing there is no app.js or index.js so in which should I import it?

This is not a React-based project. You cannot create components/import/export them. You can work on the popup.html and CSS files for the extension and then load it in the browser as mentioned to check your changes.

@artimanputra
Copy link
Contributor Author

@artimanputra Since your queries in Gitter have been cleared now, can you provide updates on this issue?

@adityabisoi yup I am on that, just tell me Shall I create a new component for the header? and one more thing there is no app.js or index.js so in which should I import it?

This is not a React-based project. You cannot create components/import/export them. You can work on the popup.html and CSS files for the extension and then load it in the browser as mentioned to check your changes.

Ohkay

@subhangi2731
Copy link
Collaborator

@artimanputra were you able to do this please let me know

@artimanputra
Copy link
Contributor Author

artimanputra commented Dec 24, 2021

@artimanputra were you able to do this please let me know
@subhangi2731 I have done the changes and now it's loading in the extension, so please check once.

BI8mGYwXBx.mp4

@adityabisoi adityabisoi merged commit 4a2b6fc into the-browser-toolbox:main Jan 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants