-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
3. As a user, I want to set up a new shopping list so I can track purchased items (continued from week 2) #49
Conversation
An index needed to be built so that we could run a compound query. I created the query without using the FirestoreCollection component so that I could get the link from the error message in the console to build the index. I'm not sure if that was necessary or not but that's how I got there.
I pulled the tab navigation out of the HomePage component and gave it it's own NavTabs component. I added the NavTabs to each page that we have so far and removed the links to List and NewList because they are now redundant.
…ab/tcl-3-smart-shopping-list into aj-np-create-new-list-token
We tested that the items associated with the saved token populate the list so it's no longer needed to show them on the list view.
Finishing up the story from last week - https://github.com/the-collab-lab/tcl-3-smart-shopping-list/wiki/(Week-2)-Monica-&-Nikema-(As-a-user,-I-want-to-set-up-a-new-shopping-list) PR: #49 Issue: Closes #25 A shopping list consists of a set of items associated with a user’s token. Tokens can be shared with other users to allow them to co-manage a given list. Creating a new list consists of the following:
The following script can be used to generate a suitable token: https://gist.github.com/segdeha/21a42618ce5a54916c5b58d36ec2992e The requested changes from Andrew: This is a great start, but is a little incomplete. Importantly, from the story description: A shopping list consists of a set of items associated with a user’s token. What I'd like to see added to what you have is the following:
You may need to add some records to the database directly to get them to display. In the next set of stories, we'll address adding items to the list in a way that stores the user's token as well (I'm a bit confused how that's already implemented because that story hasn't come up yet) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything should be work as it should be. Completed ACs for Story 3. Ready for mentor review
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, approved! Before merging, please remove any remaining console.log
statements as well as any commented out code. Thanks!
Remove commented out code and console.log statements
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I went through and removed the commented code and console.log
statements at @segdeha's request.
@ajiles91 Do you want to give the PR a final look and then merge? |
just creating initial pull request